-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapped forgot link to content #5592
Conversation
@akshayasalvi Great Job, will look into this in coming days! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple change, good job @akshayasalvi, thank you for this. We will wait for the hold to be lifted, sorry for extension, there should be bonus included as a compensation for the time you wait.
Feel free to make this ready for a review. |
Is the |
Just read this. Thank you :) Appreciate your kind words. |
Hi @akshayasalvi, The Although this PR is quite small and simple, I would prefer if we could always merge During the N6 rush, we have merged a lot of small (and some bigger) polish PRs internally and externally, so it is possible there will be some regressions and better to catch it now than in staging (or in production 😬 ). |
@mountiny Makes sense, I'll push in a while |
@mountiny Merged main and tested again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @akshayasalvi Great work on this one and thank you very much for your patience with the n6-hold
.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
@mountiny Feel free to review whenever the n6-hold is lifted :) I am keeping it in the draft right now.
Details
Fixed Issues
$ #5355
Tests
QA Steps
forgot?
textlink.Tested On
Screenshots
Web
web-forgot-link.mov
Mobile Web
mweb-forgot-link.mov
Desktop
desktop-forgot-link.mov
iOS
ios-forgot-link.mov
Android
android-forgot-link.mov