Fix input not auto-focused on mWeb #55823

linhvovan29546 · 2025-01-28T01:32:43Z

Explanation of Change

On some devices, the Lottie animation runs with high CPU usage, preventing runAfterInteractions from executing (in this case, the Text focus logic runs inside runAfterInteractions). To address this, we need to pause the animation when the screen is blurred to improve performance and prevent memory leaks. Previously, this was handled for web/desktop, but the case for mWeb was missed. This PR covers that missing case.

Fixed Issues

$ #53208
PROPOSAL: #53208 (comment)

Tests

Verify that no errors appear in the JS console

Login to new dot with an account
Create a new workspace
Go to more features > Tags > Enable tags
Navigate to tags page > Add tag
Verify Tag creation page is opened, the name input is automatically focused and keyboard is opened

Offline tests

Same above

QA Steps

Verify that no errors appear in the JS console

Login to new dot with an account
Create a new workspace
Go to more features > Tags > Enable tags
Navigate to tags page > Add tag
Verify Tag creation page is opened, the name input is automatically focused and keyboard is opened

PR Author Checklist

Screenshots/Videos

Android: Native

No, this change applies only to mWeb

Android: mWeb Chrome

media_20250128_080316_4531439591937098808.mp4

iOS: Native

No, this change applies only to mWeb

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-28.at.08.00.08.mp4

MacOS: Chrome / Safari

No, this change applies only to mWeb

MacOS: Desktop

No, this change applies only to mWeb

melvin-bot · 2025-01-28T01:45:47Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

linhvovan29546 · 2025-02-01T07:52:03Z

@rayane-djouah Could you help review this when you have a chance? Thanks!

rayane-d · 2025-02-03T09:49:04Z

Apologies for the delay, I was out sick the end of last week. reviewing now

rayane-d · 2025-02-03T09:51:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

Before:

screen-20250123-234832.mp4

After:

screen-20250123-234957.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-03.at.10.46.06.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-03.at.10.47.54.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-02-03.at.10.53.57.AM.mov

MacOS: Desktop

Screen.Recording.2025-02-03.at.10.52.57.AM.mov

linhvovan29546 · 2025-02-03T09:56:06Z

No worries, hope you're feeling better!

rayane-d

LGTM and tests well

MonilBhavsar

Thanks!

OSBotify · 2025-02-03T22:51:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-03T23:33:57Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-06T21:56:54Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-06T22:38:45Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

linhvovan29546 added 2 commits January 28, 2025 08:11

fix: pause lottie animation on mweb to prevent memory leak

4cf0923

fix: eslint fail

82d5a6b

linhvovan29546 marked this pull request as ready for review January 28, 2025 01:45

linhvovan29546 requested a review from a team as a code owner January 28, 2025 01:45

melvin-bot bot requested review from rayane-d and removed request for a team January 28, 2025 01:45

linhvovan29546 changed the title ~~Fix/53208 mweb input not auto focused~~ Fix input not auto-focused on mWeb Jan 28, 2025

rayane-d approved these changes Feb 3, 2025

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar February 3, 2025 10:50

MonilBhavsar approved these changes Feb 3, 2025

View reviewed changes

MonilBhavsar merged commit 4cfe5b2 into Expensify:main Feb 3, 2025
19 of 69 checks passed

github-actions bot mentioned this pull request Feb 3, 2025

Deploy Checklist: New Expensify 2025-02-03 #56280

Closed

95 tasks

linhvovan29546 deleted the fix/53208-mweb-input-not-auto-focused branch February 5, 2025 15:28

melvin-bot bot mentioned this pull request Feb 6, 2025

[Due for payment 2025-02-13] [$250] mWeb - Workspace - Input is not auto-focused and keyboard doesn't open when creating a tag #53208

Open

8 tasks

rayane-d mentioned this pull request Feb 8, 2025

Prevent Lottie from running in the background after navigating to other pages #48444

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix input not auto-focused on mWeb #55823

Fix input not auto-focused on mWeb #55823

linhvovan29546 commented Jan 28, 2025 •

edited

Loading

melvin-bot bot commented Jan 28, 2025

linhvovan29546 commented Feb 1, 2025

rayane-d commented Feb 3, 2025 •

edited

Loading

rayane-d commented Feb 3, 2025 •

edited

Loading

Before:

After:

linhvovan29546 commented Feb 3, 2025

rayane-d left a comment

MonilBhavsar left a comment

OSBotify commented Feb 3, 2025

github-actions bot commented Feb 3, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

Fix input not auto-focused on mWeb #55823

Fix input not auto-focused on mWeb #55823

Conversation

linhvovan29546 commented Jan 28, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 28, 2025

linhvovan29546 commented Feb 1, 2025

rayane-d commented Feb 3, 2025 • edited Loading

rayane-d commented Feb 3, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

Before:

After:

linhvovan29546 commented Feb 3, 2025

rayane-d left a comment

Choose a reason for hiding this comment

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 3, 2025

github-actions bot commented Feb 3, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

linhvovan29546 commented Jan 28, 2025 •

edited

Loading

rayane-d commented Feb 3, 2025 •

edited

Loading

rayane-d commented Feb 3, 2025 •

edited

Loading