-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no QA] Delete and replace HelpDot direct feed images #55793
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
@alitoshmatov @muttmuure One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@muttmuure removing your review as this is just adjusting images, no articles. |
@alitoshmatov please approve to go to internal approver. TY! |
This comment was marked as off-topic.
This comment was marked as off-topic.
@cristipaval @kadiealexander One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🎯 @alitoshmatov, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55802. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
A preview of your ExpensifyHelp changes have been deployed to https://ab395beb.helpdot.pages.dev ⚡️ |
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.91-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.91-2 🚀
|
Explanation of Change
Deleting existing direct feed help site images and replace them with a new set that has all the correctly updated copy based on our recent product changes. These images aren't yet used in any helpdot articles, so no concerns about updating any references in articles.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/439387
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined