Fix new messages indicator after comment linking #55582

janicduplessis · 2025-01-21T23:27:17Z

Explanation of Change

This fixes the new messages indicator that should appear after comment linking, even if no new messages exist. The logic it used to detect if it was a comment link didn't work anymore since #52149, and I think doing it this way is better and more reliable.

What we do is check the index of the linked message and if it is bigger than 5 (arbitrary number to say we are far from the start of the chat) and leverage the existing isFloatingMessageCounterVisible state. We also check in an effect when the route change to make sure it is displayed again when linking to a message in the same chat.

Fixed Issues

$ #55530
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Test QA steps

Offline tests

QA Steps

Verify that no errors appear in the JS console
Follow the test steps from [Due for payment 2025-02-04] Chat - Popup navigation is not seen for account that sent link of a comment #55530

Pre-condition:

Create a chat between Account A and Account B.
Send 200 messages from Account A to Account B.
Copy the link to the 70th message and send it to Account B (first link).
Copy the link to the 150th message and send it to Account B (second link).

Steps :

Sign in to staging.new.expensify.com with Account A from the pre-condition
Navigate to the conversation with Account B
Click on the first or the second link sent from the pre-condition above

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.12.41.14.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.12.46.01.mov

iOS: Native

Screen.Recording.2025-01-22.at.12.26.19.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.12.07.05.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-21.at.18.24.50.mov

MacOS: Desktop

melvin-bot · 2025-01-21T23:27:22Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-01-22T02:07:16Z

Bug 1: Click on "New messages" indicator, it doesn't scroll to the latest message

Screen.Recording.2025-01-22.at.09.01.30.mov

janicduplessis · 2025-01-22T05:18:12Z

@hoangzinh Ok I found the problem, when trying to scroll at the bottom of the list, we also need to adjust the displayed data in BaseInvertedFlatList. This is also a regression from #52149.

hoangzinh · 2025-01-22T10:45:10Z

Thank you @janicduplessis

hoangzinh · 2025-01-22T10:45:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.23.02.10.android.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.23.03.53.android.chrome.mov

iOS: Native

Screen.Recording.2025-01-22.at.23.08.09.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.23.04.43.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.22.59.35.desktop.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.22.51.52.web.mov

hoangzinh · 2025-01-22T11:02:12Z

The logic it used to detect if it was a comment link didn't work anymore since #52149

@janicduplessis could you quickly share which logic was used to detect the comment link didn't work since above PR?

hoangzinh · 2025-01-22T11:37:28Z

src/pages/home/report/ReportActionsList.tsx

+    // Display the new message indicator when comment linking and not close to the newest message.
+    const reportActionID = route?.params?.reportActionID;
+    const indexOfLinkedAction = reportActionID ? sortedVisibleReportActions.findIndex((action) => action.reportActionID === reportActionID) : -1;
+    const isLinkedActionCloseToNewest = indexOfLinkedAction < 5;


Based on testing in Prod, it should be 15 or something. Btw, we should move this into a constant

Screen.Recording.2025-01-22.at.18.30.28.mov

Beamanator · 2025-01-22T14:56:24Z

Hey gents, any updates? 🙏

hoangzinh · 2025-01-22T14:57:57Z

@Beamanator I just ping @janicduplessis in Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1737557782650459?thread_ts=1737467569.939969&cid=C01GTK53T8Q.

I tested this PR and it fixed DB, but just small feedback here #55582 (comment). Not sure if it's a blocker

janicduplessis · 2025-01-22T15:40:30Z

Before #52149 we used to paginate the cached messages in ReportActionsView to be able to start the list at a specific message, now that pagination is done in BaseInvertedFlatList. Some code checks hasNewestReportAction to detect comment linking since before it would be false because ReportActionsList would only see a subset of the cached message, but now it always sees all messages.

Beamanator · 2025-01-22T15:53:32Z

Thanks both, so @hoangzinh are you proceeding with the checklist? 🙏

hoangzinh · 2025-01-22T15:54:54Z

Yes @Beamanator. I just did for Web, I'm doing for remaining plaforms

hoangzinh · 2025-01-22T15:57:14Z

@janicduplessis could you add recordings for other platforms as well? Also, can you prefix "number" to testing steps for readability?

hoangzinh · 2025-01-22T16:16:30Z

@janicduplessis please also complete checkboxes under QA sections

Beamanator

LGTM!

OSBotify · 2025-01-23T07:25:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:29:58Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:53:30Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Fix new messages indicator after comment linking

80d3237

janicduplessis requested a review from a team as a code owner January 21, 2025 23:27

melvin-bot bot requested review from hoangzinh and removed request for a team January 21, 2025 23:27

janicduplessis added 2 commits January 22, 2025 00:13

Fix scroll to bottom

ab86c36

Merge branch 'main' into @janic/fix-cl-indicator

394bfb9

hoangzinh reviewed Jan 22, 2025

View reviewed changes

Move is close to newest to const and adjust value

2edfb45

hoangzinh approved these changes Jan 22, 2025

View reviewed changes

melvin-bot bot requested a review from youssef-lr January 22, 2025 17:49

Merge branch 'main' into @janic/fix-cl-indicator

4053a49

Beamanator approved these changes Jan 23, 2025

View reviewed changes

Beamanator merged commit 4b384c7 into Expensify:main Jan 23, 2025
16 checks passed

janicduplessis deleted the @janic/fix-cl-indicator branch January 23, 2025 17:11

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

neil-marcellini mentioned this pull request Jan 23, 2025

Revert "Fix new messages indicator after comment linking" #55664

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix new messages indicator after comment linking #55582

Fix new messages indicator after comment linking #55582

janicduplessis commented Jan 21, 2025 •

edited

Loading

melvin-bot bot commented Jan 21, 2025

hoangzinh commented Jan 22, 2025

janicduplessis commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

hoangzinh commented Jan 22, 2025 •

edited

Loading

hoangzinh commented Jan 22, 2025

hoangzinh Jan 22, 2025

Beamanator commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

janicduplessis commented Jan 22, 2025

Beamanator commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

Beamanator left a comment

OSBotify commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

Fix new messages indicator after comment linking #55582

Fix new messages indicator after comment linking #55582

Conversation

janicduplessis commented Jan 21, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Pre-condition:

Steps :

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 21, 2025

hoangzinh commented Jan 22, 2025

janicduplessis commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

hoangzinh commented Jan 22, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Jan 22, 2025

hoangzinh Jan 22, 2025

Choose a reason for hiding this comment

Beamanator commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

janicduplessis commented Jan 22, 2025

Beamanator commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

hoangzinh commented Jan 22, 2025

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

janicduplessis commented Jan 21, 2025 •

edited

Loading

hoangzinh commented Jan 22, 2025 •

edited

Loading