-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: in debug menu toggle action delay #55442
fix: in debug menu toggle action delay #55442
Conversation
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-21.at.1.41.23.AM.movAndroid: mWeb Chromeandroid_mweb_chrome.mp4iOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-21.at.01.52.11.mp4iOS: mWeb SafariUntitled.mp4MacOS: Chrome / SafariScreen.Recording.2025-01-20.at.11.16.29.PM.movMacOS: DesktopScreen.Recording.2025-01-20.at.11.17.07.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well
@dangrous all yours! |
Congrats, that's your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It's an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.89-0 🚀
|
This issue is related to the Modal component. I think we can log it so that a BZ team member or an internal engineer can determine whether it should be fixed |
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀
|
@mvtglobally yeah that's unrelated to this PR but would definitely be good to log and fix, if you haven't already. Thank you! |
Explanation of Change
The
Lottie
animation consumes high CPU, preventing therunAfterInteractions
callback from executing. This happens becauseInteractionManager
schedules long-running work only after all interactions and animations have completed.So we need to replace
InteractionManager
torequestAnimationFrame
Fixed Issues
$ #54767
PROPOSAL: #54767 (comment)
Tests
Offline tests
Same above
QA Steps
Same above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
toggle-android-native.mp4
Android: mWeb Chrome
toggle-android-mweb.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-18.at.10.29.20.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-18.at.08.33.04.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-01-18.at.8.15.14.AM.mov
MacOS: Desktop
Screen.Recording.2025-01-18.at.8.43.06.AM.mov