-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add files via upload #55170
[No QA] Add files via upload #55170
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @CherylWalsh |
@sobitneupane @CherylWalsh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://7a82ff8c.helpdot.pages.dev ⚡️ |
@OfstadC Which page should the image appear on? I couldn't find it at https://7a82ff8c.helpdot.pages.dev/ |
@sobitneupane it will end up here - I haven't added the section yet. Should I do that first? |
@sobitneupane Submitted PR to update help dot text here - #55611 The image file will go under:
|
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@rlinoz @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🎯 @sobitneupane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #55613. |
Leaving a note for the Reviewer Checklist above. Technically, this is just an image upload, so the checklist above doesn't really apply. Nonetheless, I've marked it as complete so we can push this up. |
🚀 Deployed to staging by https://github.com/johncschuster in version: 9.0.89-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀
|
Explanation of Change
Adding image to Tavel help page (specifically unlinking travel policies)
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/454966
PROPOSAL:https://github.com/Expensify/Expensify/issues/454966#issuecomment-2581991907
Tests
No tests needed
Offline tests
No tests needed
QA Steps
No QA needed
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop