Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DatePicker component #5509
Add DatePicker component #5509
Changes from 29 commits
37135b9
125894a
f8ac6b6
c1922b8
a2c9fa5
5226357
03ad0e5
c149599
9f647d5
b29b1c6
215a925
3173150
014e4f8
52beb8d
e0259b6
374f3a3
73fbf05
0b2e111
6eb8946
3d15dd8
8019668
fcb1687
0a6174c
4325871
0f710a2
9a3e83b
9db7aa9
71a8c32
f635517
dfb3d17
61f0f61
859e196
00799de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB but maybe useful to mention somewhere that iOS is the only platform where we have to manage localization ourselves, and on all others it's controlled by the OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open a separate request to put a note about this
We're localizing the "Reset" and "Done" button that we put on our own popup.
RNDatepicker
would be shown in the system locale. I'm passing thelocale
toRNDatepicker
because it will be weird to have the "Done" and "Reset" buttons in one locale and the picker months in another - it can happenOn Android the buttons and the modal are handled by the system so they are always in the system locale