Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy Personal Information Step Terms & Regulations #5417

Merged
merged 6 commits into from
Sep 28, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Sep 22, 2021

Details

This PR formats the Onfido disclaimers in Personal information.

Fixed Issues

$ #5342

Tests

  1. Login to NewDot with an account that has a Workspace and no Expensify Card enabled.
  2. Navigate to /bank-account/personal-information or Settings > Select Workspace > Expensify Card > Get started
  3. Verify that the Onfido disclaimer looks like the screenshots below.
  4. Click the links and verify that they open in a new tab and the correct pages show up (Note: as discussed here, link hover/pressed effects do not work)

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mweb

Desktop

desktop

iOS

ios

Android

android

@luacmartins luacmartins self-assigned this Sep 22, 2021
@luacmartins luacmartins requested a review from a team September 22, 2021 17:01
@luacmartins luacmartins marked this pull request as ready for review September 22, 2021 17:01
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team September 22, 2021 17:02
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my favorite fix since TextLink is supposed to be equivalent 😂 , but I'll let this pass to fix it in the interim if we're having styling quirk.s

@johnmlee101 johnmlee101 merged commit 8db0dd0 into main Sep 28, 2021
@johnmlee101 johnmlee101 deleted the cmartins-formatPersonalInfo branch September 28, 2021 15:26
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @johnmlee101 in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants