Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont toggle create menu if we already have a free policy #5394

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Dont toggle create menu if we already have a free policy #5394

merged 4 commits into from
Sep 23, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 21, 2021 •
edited
Loading

Details

Fixed Issues

$ #5392

Tests / QA Steps

Test that global create does not open when creating a policy view OldDot

  1. Log out of New Dot
  2. Create a new account with a private domain via OldDot
  3. Navigate to the group policies page and create a Free policy
  4. Verify that you land in the Workspace Settings page in NewDot and the global create menu does not open

Test that global create does not open when navigating to a free policy

  1. Log out of New Dot
  2. Using the same account navigate to the group policies page and select the free policy
  3. Verify that you land in the Workspace Settings page in NewDot and the global create menu does not open

Test that logging into NewDot with a new account does open the menu

  1. Log out of New Dot
  2. Create a new account with a private domain via NewDot and validate it
  3. Verify that the create menu opens and has an option to create a workspace

Test that logging into NewDot with a new account does not open the menu

  1. Log out of New Dot
  2. Log in with the account you created just now and verify the create menu does not open

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Sep 21, 2021
@marcaaron
Copy link
Contributor Author

I don't think this solution should have to change at all in order for this to work

@marcaaron
Copy link
Contributor Author

Scratch that it does need to be updated... one sec...

@marcaaron marcaaron changed the title [HOLD] Dont toggle create menu if we already have a free policy Dont toggle create menu if we already have a free policy Sep 22, 2021
@marcaaron marcaaron marked this pull request as ready for review September 22, 2021 21:04
@marcaaron marcaaron requested a review from a team as a code owner September 22, 2021 21:04
@MelvinBot MelvinBot requested review from mountiny and removed request for a team September 22, 2021 21:04
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron merged commit 8987627 into main Sep 23, 2021
@marcaaron marcaaron deleted the marcaaron-hideCreateMenuOnNewDotRedirect branch September 23, 2021 01:43
github-actions bot pushed a commit that referenced this pull request Sep 23, 2021
@marcaaron
Merge pull request #5394 from Expensify/marcaaron-hideCreateMenuOnNew…
4fc17c7 
…DotRedirect

Dont toggle create menu if we already have a free policy

(cherry picked from commit 8987627)
This was referenced Sep 23, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcaaron in version: 1.1.1-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Sep 23, 2021
Closed
27 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cead22 cead22 cead22 approved these changes

@iwiznia iwiznia iwiznia approved these changes

@TomatoToaster TomatoToaster TomatoToaster approved these changes

@mountiny mountiny Awaiting requested review from mountiny

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcaaron @OSBotify @cead22 @iwiznia @TomatoToaster