Fix - Web - Search - New messages are not updated automatically in chats section #53482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
mananjadhav
and removed request for
a team
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Reviewing. |
mananjadhav
reviewed
Dec 8, 2024
mananjadhav
reviewed
Dec 8, 2024
mananjadhav
reviewed
Dec 8, 2024
mananjadhav
reviewed
Dec 8, 2024
mananjadhav
reviewed
Dec 8, 2024
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-new-messages.movAndroid: mWeb Chromemweb-chrome-new-messages.moviOS: NativeiOS: mWeb Safarimweb-safari-new-messages.movMacOS: Chrome / Safariweb-new-messages.movMacOS: Desktopdesktop-new-messages.mov |
|
I have some issues with my pod install. The change is tested in all the other platforms. Approving this. Will try to upload the iOS screenshot later. |
mananjadhav
approved these changes
Dec 10, 2024
| useEffect(() => { | ||
| const previousTransactionsLength = previousTransactions && Object.keys(previousTransactions).length; | ||
| const transactionsLength = transactions && Object.keys(transactions).length; | ||
|
|
||
| // Return early if search was already triggered or there's no change in transactions length | ||
| if (searchTriggeredRef.current || previousTransactionsLength === transactionsLength) { | ||
| const reportActionsLength = reportActions && Object.values(reportActions).reduce((sum, curr) => sum + Object.keys(curr ?? {}).length, 0); |
There was a problem hiding this comment.
I think this can be changed to this, no?
Suggested change
| const reportActionsLength = reportActions && Object.values(reportActions).reduce((sum, curr) => sum + Object.keys(curr ?? {}).length, 0); | |
| const reportActionsLength = reportActions && Object.values(reportActions).length; |
And also below
There was a problem hiding this comment.
Nope @marcochavezf the structure of reportActions is
{
reportAction_reportID:{
reportActionID:{},
reportActionID2:{}
...
}
}
There was a problem hiding this comment.
Oh cool, thanks for the clarification!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
60 tasks
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.76-0 🚀
|
luacmartins
removed
the
DeployBlockerCash
8 tasks
|
🚀 Deployed to production by https://github.com/grgia in version: 9.0.76-12 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #52193
PROPOSAL: #52193 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
a.highlight.mp4
Android: mWeb Chrome
aw.mp4
iOS: Native
i.mp4
iOS: mWeb Safari
iw.mp4
MacOS: Chrome / Safari
w.mp4
MacOS: Desktop
d.mp4