-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] [Chore] Bump reanimated & update API to comply with react-compiler #52825
[NoQA] [Chore] Bump reanimated & update API to comply with react-compiler #52825
Conversation
daf5c07
to
3e5e1f3
Compare
…abs/expensify-app-fork into chore/bump-reanimated
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@luacmartins Let's do an adhoc build, to make sure it builds well 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eVoloshchak all yours |
🚧 @luacmartins has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeXRecorder_27112024_232656.mp4Android: mWeb ChromeXRecorder_27112024_232938.mp4iOS: NativeScreen.Recording.2024-11-27.at.9.36.33.PM.moviOS: mWeb SafariWhatsApp.Video.2024-11-27.at.23.18.58.mp4MacOS: Chrome / SafariScreen.Recording.2024-11-27.at.11.31.15.PM.movMacOS: DesktopScreen.Recording.2024-11-27.at.11.34.49.PM.mov |
I will test on the Ad-Hoc builds itself for faster testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, things looked fine while testing.
Tested adhoc bulids for all platforms 🚀
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.68-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀
|
Explanation of Change
value
propertyFixed Issues
$ #52024
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
reanimate.bump.android.mov
Android: mWeb Chrome
android.web.mov
iOS: Native
reanimate.bump.ios.mov
iOS: mWeb Safari
ios.web.mov
MacOS: Chrome / Safari
web.recording.mov