Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off eslint caching #519

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Turn off eslint caching #519

merged 3 commits into from
Sep 22, 2020

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Sep 22, 2020

Fixes #301

Tests

  1. Create an eslint error in the code
  2. Verify the linter catches it
  3. Fix the eslint error
  4. Verify the linter is happy

@tgolen tgolen requested a review from marcaaron September 22, 2020 15:16
@tgolen tgolen requested a review from AndrewGable as a code owner September 22, 2020 15:16
@tgolen tgolen self-assigned this Sep 22, 2020
@@ -48,7 +48,6 @@ module.exports = {
loader: 'eslint-loader',
exclude: /node_modules|\.native.js$/,
options: {
cache: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% positive, but I think if we want to disable this then we need to do cache: false as the default looks like this when we are in "development" mode...

cache: {
    type: 'memory',
},

https://webpack.js.org/configuration/other-options/#cache

@tgolen
Copy link
Contributor Author

tgolen commented Sep 22, 2020

OK, updated to set caching to false

@marcaaron marcaaron merged commit 0fc2d1a into master Sep 22, 2020
@marcaaron marcaaron deleted the tgolen-stop-eslint-caching branch September 22, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something is up with Webpack eslint-loader caching
2 participants