[No QA]Fix iOS production deploys #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
previously approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Overall I don't know enough about each of these flags to really critique, but I'm really glad you were able to test locally and hopefully figure it out. Let's see if it works in the wild!
Beyond the one comment about echoing the IOS_VERSION from the GH Workflow, the only other NAB I have is that we should have a blank line above each new comment in the Fastfile, if possible. It's just a bit hard to read as-is.
roryabraham
approved these changes
Sep 2, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
54 tasks
|
🚀 Deployed to staging by @roryabraham in version: 1.0.92-1 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Debugged fastlane locally and was able to submit production builds using this code. I believe production should fail once more, then it should run this code and succeed.
Fixed Issues
$ #4978
Tests
I ran these locally, if you do not have the secrets decrypted this will not work
bundle exec fastlane ios production