-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internationalization beta #4967
Conversation
|
cc @iwiznia Because internationalization was originally your project I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Tested in web and Android.
We may want to create a follow up GH issue to keep the chosen language once we login or signup.
Reported in #expensify-open-source 👍 |
Merging to resolve deploy blocker |
…onBeta Remove internationalization beta (cherry picked from commit 9a06c42)
🚀 Cherry-picked to staging by @roryabraham in version: 1.0.90-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
🚀 Deployed to staging by @roryabraham in version: 1.0.90-3 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀
|
Oh crap! I was OOO and did not catch this. We should not remove the beta, the internationalization project is still one, given we only have one language and that we have not internationalized the server (and thus a lot of the messaging people see). Remember we only added internationalization early in the App so that it would be easier to internationalize later. |
@iwiznia thanks for the context, I'll put up a revert PR for this |
Details
The locale picker cannot be used from the signup or login pages because betas are not yet available (because the user is not logged in). Dropped a message in Slack here, but I feel like at this point we can safely remove this beta entirely.
Fixed Issues
$ #4958
Note: The above issue is not reproducible on dev, because all betas are enabled by default.
Tests / QA Steps
Screenshots
Not including screenshots because it looks the same on dev as it did before – this change will only be visible on staging.