Fix crash after leaving group as the last member #48096

bernhardoj · 2024-08-27T14:40:03Z

Details

Leaving group chat as the last member will crash the app. This PR fixes it.

Fixed Issues

$ #48072
PROPOSAL: #48072 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-08-27T14:40:09Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-08-27T14:44:59Z

Thanks for the PR. It seems this DB comes from my previous PR that I reviewed, I'll take this one

hungvu193 · 2024-08-27T14:56:10Z

src/pages/home/report/ReportActionItem.tsx

@@ -178,7 +178,8 @@ function ReportActionItem({
    const {translate} = useLocalize();
    const {shouldUseNarrowLayout} = useResponsiveLayout();
    const blockedFromConcierge = useBlockedFromConcierge();
-    const originalReportID = useMemo(() => ReportUtils.getOriginalReportID(report.reportID, action) ?? '-1', [report.reportID, action]);
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+    const originalReportID = useMemo(() => ReportUtils.getOriginalReportID(report.reportID, action) || '-1', [report.reportID, action]);


There are few other places that we're using originalReportID ?? '-1', do you think we should update them as well?

App/src/libs/actions/ReportActions.ts

Line 35 in 6ca91cd

const linkedTransactionID = ReportActionUtils.getLinkedTransactionID(reportAction.reportActionID, originalReportID ?? '-1');

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

Line 214 in 6ca91cd

originalReportIDRef.current = originalReportID ?? '-1';

I think it would be safe to do it, but I think it's best that we have a guideline to use || instead of ?? for string and update them all in one issue (break in several PRs perhaps).

Can we just update these 2 places here? And then we can discuss about the second part later.

cc @cristipaval

OR, can we update getOriginalReportID to return undefined instead empty string?

I think returning reportID || undefined looks unclean.

I have updated to use || for now. We can revert it if @cristipaval disagrees

Btw, I'm currently having trouble running the native app.

Same here :/ I can't run native too

Can we raise this for discussion somewhere?

Yeah there was a thread here: https://expensify.slack.com/archives/C01GTK53T8Q/p1724842994690509

hungvu193 · 2024-08-27T15:27:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-08-27.at.22.33.49.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-08-27.at.22.28.26.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-27.at.22.25.55.mov

MacOS: Desktop

Screen.Recording.2024-08-27.at.22.27.21.mov

OSBotify · 2024-08-27T16:19:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…eaving-group Fix crash after leaving group as the last member (cherry picked from commit 9c0c647) (CP triggered by puneetlath)

puneetlath · 2024-08-27T17:14:23Z

@cristipaval confirmed it's fixed on staging

OSBotify · 2024-08-27T17:39:30Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.0.25-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

fallback using double pipe

b6faa55

bernhardoj requested a review from a team as a code owner August 27, 2024 14:40

melvin-bot bot requested review from rayane-d and removed request for a team August 27, 2024 14:40

supress lint

ddbe832

hungvu193 reviewed Aug 27, 2024

View reviewed changes

use double pipe

c7d65ab

hungvu193 approved these changes Aug 27, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval August 27, 2024 15:30

puneetlath approved these changes Aug 27, 2024

View reviewed changes

puneetlath merged commit 9c0c647 into Expensify:main Aug 27, 2024
17 of 20 checks passed

OSBotify pushed a commit that referenced this pull request Aug 27, 2024

Merge pull request #48096 from bernhardoj/fix/48072-app-crash-after-l…

83cd596

…eaving-group Fix crash after leaving group as the last member (cherry picked from commit 9c0c647) (CP triggered by puneetlath)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Aug 27, 2024

github-actions bot mentioned this pull request Aug 27, 2024

Deploy Checklist: New Expensify 2024-08-26 #48035

Closed

roryabraham mentioned this pull request Aug 27, 2024

Clean up draft message subscriptions #47861

Closed

puneetlath mentioned this pull request Sep 21, 2024

mWeb - Group chat - After removing member, admin leaving group chat app crashes #48072

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash after leaving group as the last member #48096

Fix crash after leaving group as the last member #48096

bernhardoj commented Aug 27, 2024 •

edited

Loading

melvin-bot bot commented Aug 27, 2024

hungvu193 commented Aug 27, 2024

hungvu193 Aug 27, 2024

bernhardoj Aug 27, 2024

hungvu193 Aug 27, 2024

hungvu193 Aug 27, 2024

bernhardoj Aug 27, 2024

bernhardoj Aug 27, 2024

hungvu193 Aug 27, 2024

puneetlath Aug 27, 2024

hungvu193 Aug 29, 2024

hungvu193 commented Aug 27, 2024 •

edited

Loading

OSBotify commented Aug 27, 2024

puneetlath commented Aug 27, 2024

OSBotify commented Aug 27, 2024

Fix crash after leaving group as the last member #48096

Fix crash after leaving group as the last member #48096

Conversation

bernhardoj commented Aug 27, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 27, 2024

hungvu193 commented Aug 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Aug 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Aug 27, 2024

puneetlath commented Aug 27, 2024

OSBotify commented Aug 27, 2024

bernhardoj commented Aug 27, 2024 •

edited

Loading

hungvu193 commented Aug 27, 2024 •

edited

Loading