Add new read commands for the workspace profile and initial settings pages - v2 #44902

fedirjh · 2024-07-05T13:19:55Z

Details

This is a revised version of PR #42901 :

In this PR, we are simply adding a new API call to OpenPolicyProfilePage and its alias OpenPolicyInitialPage. These are two endpoints for the 1:1:1 but in both, we are loading the policy data to make sure the policy settings/ feature options are shown correctly.
The OpenPolicyInitialPage is called in narrow view only when the workspace settings options (features) are shown. If you then select the Profile option, we also call the OpenPolicyProfilePage.
In wide view, the OpenPolicyInitialPage is never called and only the OpenPolicyProfilePage is going to be triggered as that is the default main page the user is navigated to when they open the workspace settings
We have addressed the issue where a read call was being made before the workspace was created and fixed it.

Fixed Issues

$ #41914
$ #44601
#41914 (comment)

Tests

Test 1 :

Log into an account which owns a workspace
Navigate to settings
Navigate to workspaces
Open Console > Networks tab
Open the workspace
Verify one OpenPolicyProfilePage API read call was done
Navigate to Members page
Verify only OpenWorkspaceMembersPage API call was done
Resize the window to narrow layout
Go back to the workspace settings LHN
Verify that only one OpenPolicyInitialPage API call was made

Test 2 :

Navigate to https://staging.new.expensify.com/
Log in with a new expensifail account
Click on FAB - New workspace
Verify the Profile page is filled with content.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

CleanShot.2024-07-05.at.15.31.02.mp4

Android: mWeb Chrome

CleanShot.2024-07-05.at.15.34.33.mp4

iOS: Native

CleanShot.2024-07-05.at.15.21.26.mp4

iOS: mWeb Safari

CleanShot.2024-07-05.at.15.26.11.mp4

MacOS: Chrome / Safari

CleanShot.2024-07-05.at.14.43.32.mp4

MacOS: Desktop

CleanShot.2024-07-05.at.15.13.59.mp4

…parameters

github-actions · 2024-07-05T13:59:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44902/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44902/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44902/NewExpensify.dmg	https://44902.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2024-07-05T14:36:31Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

LGTM, thank you

hungvu193 · 2024-07-05T15:11:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-05.at.23.29.51.mov

Android: mWeb Chrome

Screen.Recording.2024-07-05.at.22.55.52.mov

iOS: Native

Screen.Recording.2024-07-05.at.22.44.27.mov

iOS: mWeb Safari

Screen.Recording.2024-07-05.at.22.46.29.mov

MacOS: Chrome / Safari

chrome.mp4

Screen.Recording.2024-07-05.at.22.33.27.mov

MacOS: Desktop

Screen.Recording.2024-07-05.at.22.27.11.mov

hungvu193 · 2024-07-05T15:20:53Z

@mountiny This is not related to this PR but we're having duplicate API call on workspace pages:

Screen.Recording.2024-07-05.at.22.20.18.mov

fedirjh · 2024-07-05T15:34:44Z

This is not related to this PR but we're having duplicate API call on workspace pages:

@hungvu193 The issue is connected to react strict mode, not limited only to workspace pages; all requests in dev are duplicated.

hungvu193 · 2024-07-05T15:36:33Z

This is not related to this PR but we're having duplicate API call on workspace pages:

@hungvu193 The issue is connected to react strict mode, not limited only to workspace pages; all requests in dev are duplicated.

Oh dang! I forgot we enabled strict mode so component will re-render few more times. Thanks for the information!

hungvu193

LGTM!

hungvu193 · 2024-07-05T15:58:32Z

src/pages/workspace/WorkspaceProfilePage.tsx

-    // When we create a new workspaces, the policy prop will not be set on the first render. Therefore, we have to delay rendering until it has been set in Onyx.
-    if (policy === undefined) {
-        return null;
-    }
-


Nice one!
This fixes issue where we have a little delay after creating workspace 👍

mountiny

Thanks for the quick work

hungvu193 · 2024-07-05T16:26:26Z

@mountiny can you please assign me to the issue to handle the payment? Thank you 😄

OSBotify · 2024-07-05T16:32:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:58:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:55:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:07:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:26:14Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh added 4 commits July 5, 2024 13:16

[Chore]: Add openPolicyProfilePage and openPolicyInitialPage and API …

bfb59a4

…parameters

[Chore]: Add profile page to withPolicy HOC

4450e8d

[Chore]: Use openPolicyInitialPage in WorkspaceInitialPage

7c06299

[Chore]: use openPolicyProfilePage in WorkspaceProfilePage

3c7a6a1

mountiny added the Ready To Build label Jul 5, 2024

mountiny assigned fedirjh Jul 5, 2024

[Chore]: Fix prettier

7aedbf9

[Chore]: Fix prettier

30c5860

fedirjh marked this pull request as ready for review July 5, 2024 14:36

fedirjh requested a review from a team as a code owner July 5, 2024 14:36

melvin-bot bot requested review from dukenv0307 and removed request for a team July 5, 2024 14:36

mountiny requested review from hungvu193 and removed request for dukenv0307 July 5, 2024 14:43

mountiny previously approved these changes Jul 5, 2024

View reviewed changes

[Fix]: use policyDraft in WorkspaceProfilePage

b99d555

fedirjh dismissed mountiny’s stale review via b99d555 July 5, 2024 15:41

[Chore]: Add comment

886eecc

hungvu193 approved these changes Jul 5, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals July 5, 2024 15:57

hungvu193 reviewed Jul 5, 2024

View reviewed changes

fedirjh requested a review from mountiny July 5, 2024 16:01

mountiny approved these changes Jul 5, 2024

View reviewed changes

mountiny merged commit ffd72fb into Expensify:main Jul 5, 2024
16 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

fedirjh deleted the workspace-profile-commands branch July 8, 2024 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new read commands for the workspace profile and initial settings pages - v2 #44902

Add new read commands for the workspace profile and initial settings pages - v2 #44902

fedirjh commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024

melvin-bot bot commented Jul 5, 2024

mountiny left a comment

hungvu193 commented Jul 5, 2024 •

edited

Loading

hungvu193 commented Jul 5, 2024

fedirjh commented Jul 5, 2024

hungvu193 commented Jul 5, 2024

hungvu193 left a comment

hungvu193 Jul 5, 2024

mountiny left a comment

hungvu193 commented Jul 5, 2024

OSBotify commented Jul 5, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

Add new read commands for the workspace profile and initial settings pages - v2 #44902

Add new read commands for the workspace profile and initial settings pages - v2 #44902

Conversation

fedirjh commented Jul 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Test 1 :

Test 2 :

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Jul 5, 2024

melvin-bot bot commented Jul 5, 2024

mountiny left a comment

Choose a reason for hiding this comment

hungvu193 commented Jul 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Jul 5, 2024

fedirjh commented Jul 5, 2024

hungvu193 commented Jul 5, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

hungvu193 Jul 5, 2024

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

hungvu193 commented Jul 5, 2024

OSBotify commented Jul 5, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

fedirjh commented Jul 5, 2024 •

edited

Loading

hungvu193 commented Jul 5, 2024 •

edited

Loading