Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incorporationState as required field in Bank Account flow #4479

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 6, 2021

@jasperhuangg will you please review this

Details

This PR adds a missing required field on the CompanyStep in the Bank Account flow

Fixed Issues

Follow-up to https://github.com/Expensify/App/pull/4272/files coming from slack convo

Tests/QA

  1. Navigate to the company step in the VBA flow: <baseURL>/bank-account/company.
  2. These are the fields that need to be filled out in order for the "Save & Continue" button to be enabled. Verify that the button is disabled if any of these fields aren't filled out. You don't need to input a valid value, any value will suffice as long as it isn't empty:
    • Legal Business Name
    • Company Address
    • City (for company address)
    • State (for company address)
    • Zip Code (for company address)
    • Company Website
    • Tax ID Number
    • Incorporation Date
    • Incorporation State
    • Industry Classification Code
    • Expensify Password

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

@Jag96 Jag96 requested a review from jasperhuangg August 6, 2021 22:50
@Jag96 Jag96 self-assigned this Aug 6, 2021
@Jag96 Jag96 requested a review from a team as a code owner August 6, 2021 22:50
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team August 6, 2021 22:51
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasperhuangg jasperhuangg merged commit f11803d into main Aug 9, 2021
@jasperhuangg jasperhuangg deleted the joe-add-required-field branch August 9, 2021 16:26
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kevinksullivan
Copy link
Contributor

Just to confirm @Jag96 , after this change is live, will Save and Continue become tappable even when the restricted banks checkbox is not selected?

image

@Jag96
Copy link
Contributor Author

Jag96 commented Aug 10, 2021

Looks like that is still an issue on master, I'll create a follow-up PR

@Jag96
Copy link
Contributor Author

Jag96 commented Aug 10, 2021

PR created #4531

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @jasperhuangg in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants