-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InternalQA] Update Onyx after validating bank account #4474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a question / NAB. Onyx is capable of batching merges, but it doesn't always lead to the clearest code IMO.
Updated! |
Self-merging as discussed 1:1 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @luacmartins in version: 1.0.83-2 🚀
|
Hi @luacmartins, any chance you can run the internal QA steps and check this PR off #4554 if it works please? Thanks! |
Waiting for the validation codes here https://github.com/Expensify/Expensify/issues/173744 |
Steps confirmed in staging! |
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173086
$ #4466
Tests
Get Started
PENDING
state.isUsingExpensifyCard:true
here so we can simulate auto provisioning of the card.Manage Card
.QA Steps
Internal QA. Steps above.
Tested On
Screenshots
Web
web-1.mov
web-2.mov
Mobile Web
Desktop
iOS
Android