Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InternalQA] Update Onyx after validating bank account #4474

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

luacmartins
Copy link
Contributor

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173086
$ #4466

Tests

  1. Login into an account without the Expensify Card or Withdrawal Bank account setup.
  2. Create a New Workspace
  3. Click on Get Started
  4. Follow this SO to setup an account in the PENDING state.
  5. Follow this SO to grab the validating codes.
  6. Verify that the account is validated but now you see this step:

Screen Shot 2021-08-06 at 3 03 46 PM

  1. Repeat steps 1-6 but applying isUsingExpensifyCard:true here so we can simulate auto provisioning of the card.
  2. Verify that the modal closes and the button changes to Manage Card.

QA Steps

Internal QA. Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-1.mov
web-2.mov

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins requested a review from a team August 6, 2021 21:41
@luacmartins luacmartins self-assigned this Aug 6, 2021
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team August 6, 2021 21:41
@luacmartins luacmartins requested a review from a team as a code owner August 6, 2021 21:45
@MelvinBot MelvinBot removed the request for review from a team August 6, 2021 21:45
marcaaron
marcaaron previously approved these changes Aug 9, 2021
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a question / NAB. Onyx is capable of batching merges, but it doesn't always lead to the clearest code IMO.

src/libs/actions/BankAccounts.js Outdated Show resolved Hide resolved
@luacmartins
Copy link
Contributor Author

Updated!

@luacmartins luacmartins requested a review from marcaaron August 9, 2021 17:01
@luacmartins
Copy link
Contributor Author

Self-merging as discussed 1:1

@luacmartins luacmartins merged commit c8bc3ec into main Aug 9, 2021
@luacmartins luacmartins deleted the cmartins-manage-card branch August 9, 2021 22:45
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@francoisl
Copy link
Contributor

Hi @luacmartins, any chance you can run the internal QA steps and check this PR off #4554 if it works please? Thanks!

@luacmartins
Copy link
Contributor Author

Waiting for the validation codes here https://github.com/Expensify/Expensify/issues/173744

@luacmartins
Copy link
Contributor Author

Steps confirmed in staging!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants