Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deleted workspaces from list #4453

Merged
merged 7 commits into from
Aug 9, 2021
Merged

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Aug 6, 2021

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173112

Tests/ QA Steps

  • Log into Newdot and add a new workspace:

Screen Shot 2021-08-06 at 3 29 43 PM

  • The workspace should now display on the Settings page:

Screen Shot 2021-08-06 at 3 30 57 PM

  • Close the settings page.

  • Log into oldDot (DO NOT log out of NewDot) and go to Policies-> group. You should see the new workspace you just created. Delete it.

  • Go back to NewDot and refresh. The workspace should be gone from the Settings page.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Not really a very screenshoty change

@Gonals Gonals requested a review from a team as a code owner August 6, 2021 13:11
@Gonals Gonals self-assigned this Aug 6, 2021
@MelvinBot MelvinBot requested review from alex-mechler and removed request for a team August 6, 2021 13:11
@Gonals Gonals changed the title Remove deleted workspaces from list [WIP] Remove deleted workspaces from list Aug 6, 2021
@Gonals Gonals changed the title [WIP] Remove deleted workspaces from list [WIP] [HOLD] Remove deleted workspaces from list Aug 6, 2021
@Gonals Gonals changed the title [WIP] [HOLD] Remove deleted workspaces from list [HOLD] Remove deleted workspaces from list Aug 6, 2021
alex-mechler
alex-mechler previously approved these changes Aug 6, 2021
@Gonals Gonals changed the title [HOLD] Remove deleted workspaces from list Remove deleted workspaces from list Aug 9, 2021
@Gonals
Copy link
Contributor Author

Gonals commented Aug 9, 2021

No longer on HOLD!

@Gonals Gonals requested a review from roryabraham August 9, 2021 21:28
@roryabraham
Copy link
Contributor

So this didn't exactly pass testing, in that I had to change this step slightly for it to work:

Go back to NewDot and refresh close and reopen the settings modal. The workspace should be gone from the Settings page.

@Gonals
Copy link
Contributor Author

Gonals commented Aug 9, 2021

So this didn't exactly pass testing, in that I had to change this step slightly for it to work:

Go back to NewDot and refresh close and reopen the settings modal. The workspace should be gone from the Settings page.

Ah, that's my bad on the instructions. Updated

src/libs/actions/Policy.js Outdated Show resolved Hide resolved
src/libs/actions/Policy.js Outdated Show resolved Hide resolved
@roryabraham
Copy link
Contributor

@Gonals lint

@Gonals
Copy link
Contributor Author

Gonals commented Aug 9, 2021

Travis happy and ready to merge, @roryabraham!

@roryabraham roryabraham merged commit 23ce910 into main Aug 9, 2021
@roryabraham roryabraham deleted the alberto-deleteWorkspaces branch August 9, 2021 23:41
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@alex-mechler
Copy link
Contributor

Thanks for taking over the review while I was out Rory!

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants