Update QBO connection copy #44124

jamesdeanexpensify · 2024-06-20T21:33:44Z

Details

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-20T23:06:18Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines · 2024-06-25T03:41:19Z

didn't have time for this one today and I'll need to merge main into this to resolve conflicts but I'll take a look tomorrow

…fy-patch-5

NikkiWines

Looks good overall, just one comment. @jamesdeanexpensify can you confirm the copy in these step-throughs looks correct?

Screen.Recording.2024-06-25.at.22.04.09.mov

Screen.Recording.2024-06-25.at.22.08.07.mov

src/languages/en.ts

NikkiWines

One other thing

NikkiWines · 2024-06-26T02:19:47Z

src/pages/workspace/accounting/qbo/export/QuickbooksNonReimbursableDefaultVendorSelectPage.tsx

@@ -73,7 +73,6 @@ function QuickbooksNonReimbursableDefaultVendorSelectPage({policy}: WithPolicyCo
            <ScreenWrapper testID={QuickbooksNonReimbursableDefaultVendorSelectPage.displayName}>
                <HeaderWithBackButton title={translate('workspace.qbo.defaultVendor')} />
                <SelectionList
-                    headerContent={<Text style={[styles.ph5, styles.pb5]}>{translate('workspace.qbo.defaultVendorDescription')}</Text>}


The import line for import Text on line 9 needs to be removed in this file

Ok I think I did that too!

jamesdeanexpensify · 2024-06-26T17:40:48Z

The videos are looking good so far! In the second one, aren't we also trying to change the header copy after you click into Purchase bill date in the Xero integration? Thank you so much!

…fy-patch-5

… into jamesdeanexpensify-patch-5

…fy-patch-5

NikkiWines

Looks good, going to assing another engineer to final review since I committed a few times to this branch to clean up some small things + merge main

Screen.Recording.2024-06-27.at.19.35.05.mov

Screen.Recording.2024-06-27.at.19.33.24.mov

melvin-bot · 2024-06-27T23:37:25Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/languages/es.ts

Co-authored-by: Rocio Perez-Cano <[email protected]>

pecanoro · 2024-06-28T16:42:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

pecanoro · 2024-06-28T16:43:37Z

@NikkiWines already tested it so just completing the checklist!

OSBotify · 2024-06-28T16:54:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:01:00Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:13:27Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T10:58:38Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:19:44Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update en.ts

deaee5a

jamesdeanexpensify self-assigned this Jun 20, 2024

jamesdeanexpensify added 10 commits June 20, 2024 14:43

Update QuickbooksCompanyCardExpenseAccountPage.tsx

f674417

Update QuickbooksCompanyCardExpenseAccountSelectCardPage.tsx

8ebc7b7

Update QuickbooksNonReimbursableDefaultVendorSelectPage.tsx

5d9ab7c

Update QuickbooksCompanyCardExpenseAccountPage.tsx

f292d93

Update QuickbooksAccountSelectPage.tsx

ed3c6c6

Update en.ts

9096a1c

Update es.ts

826844d

Update es.ts

aef3140

Update es.ts

94b43e6

Update es.ts

d19d4a1

jamesdeanexpensify requested a review from NikkiWines June 20, 2024 23:06

jamesdeanexpensify marked this pull request as ready for review June 20, 2024 23:06

jamesdeanexpensify requested a review from a team as a code owner June 20, 2024 23:06

melvin-bot bot removed the request for review from a team June 20, 2024 23:06

NikkiWines changed the title ~~Update en.ts~~ Update QBO connection copy Jun 24, 2024

Merge branch 'main' of github.com:Expensify/App into jamesdeanexpensi…

8d3a132

…fy-patch-5

NikkiWines requested changes Jun 26, 2024

View reviewed changes

src/languages/en.ts Show resolved Hide resolved

NikkiWines requested changes Jun 26, 2024

View reviewed changes

jamesdeanexpensify added 2 commits June 26, 2024 09:52

Update QuickbooksOutOfPocketExpenseEntitySelectPage.tsx

0567cfd

Update QuickbooksNonReimbursableDefaultVendorSelectPage.tsx

99d4e99

NikkiWines added 5 commits June 26, 2024 18:28

Merge branch 'main' of github.com:Expensify/App into jamesdeanexpensi…

8fcaa79

…fy-patch-5

Merge branch 'jamesdeanexpensify-patch-5' of github.com:Expensify/App…

2bb9a6b

… into jamesdeanexpensify-patch-5

Merge branch 'main' of github.com:Expensify/App into jamesdeanexpensi…

a9f91f8

…fy-patch-5

fix malformed xero consts

486cf82

formatting

1850e78

NikkiWines previously approved these changes Jun 27, 2024

View reviewed changes

NikkiWines requested a review from a team June 27, 2024 23:36

melvin-bot bot requested review from pecanoro and removed request for a team June 27, 2024 23:37

pecanoro requested changes Jun 28, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

Update src/languages/es.ts

b1666b2

Co-authored-by: Rocio Perez-Cano <[email protected]>

jamesdeanexpensify dismissed NikkiWines’s stale review via b1666b2 June 28, 2024 16:10

pecanoro approved these changes Jun 28, 2024

View reviewed changes

pecanoro merged commit b3e5886 into main Jun 28, 2024
14 of 15 checks passed

pecanoro deleted the jamesdeanexpensify-patch-5 branch June 28, 2024 16:46

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update QBO connection copy #44124

Update QBO connection copy #44124

jamesdeanexpensify commented Jun 20, 2024

melvin-bot bot commented Jun 20, 2024

NikkiWines commented Jun 25, 2024

NikkiWines left a comment

NikkiWines left a comment

NikkiWines Jun 26, 2024

jamesdeanexpensify Jun 26, 2024

jamesdeanexpensify commented Jun 26, 2024

NikkiWines left a comment

melvin-bot bot commented Jun 27, 2024

pecanoro commented Jun 28, 2024 •

edited

Loading

pecanoro commented Jun 28, 2024

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

Update QBO connection copy #44124

Update QBO connection copy #44124

Conversation

jamesdeanexpensify commented Jun 20, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 20, 2024

NikkiWines commented Jun 25, 2024

NikkiWines left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

NikkiWines Jun 26, 2024

Choose a reason for hiding this comment

jamesdeanexpensify Jun 26, 2024

Choose a reason for hiding this comment

jamesdeanexpensify commented Jun 26, 2024

NikkiWines left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 27, 2024

pecanoro commented Jun 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

pecanoro commented Jun 28, 2024

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

pecanoro commented Jun 28, 2024 •

edited

Loading