-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Password Forms Header Title #4410
Conversation
@Jag96 PR Raised. Can someone verify the Spanish translations? I've picked from Google translate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left some minor comments. I've also asked about your translations, will let you know about them when I get a response!
src/languages/en.js
Outdated
phrase4: 'Welcome back to the New Expensify! Please set your password.', | ||
phrase5: 'Welcome back to the New Expensify! Please enter your password.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move these to the setPasswordPage
translations here. Let's also give them more descriptive names like setYourPassword
and enterYourPassword
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved phrase4
to setPasswordPage.passwordFormTitle
. phrase5
is retained in welcomeText
as it is a part of the SiginInPage
flow. Let me know if you still want me to change it?
…ssword-title-label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I heard back about the translations, so I'll commit those and get this merged, thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.82-8🚀
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
@Jag96 Can you please review?
Details
welcomeText
welcomeText
prop to all the forms necessarywelcomeText
phrasesFixed Issues
$ #4315
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android