Treat Default Chat Rooms like Multiple Participant Rooms when it comes to their OptionRow->login property #4393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomatoToaster please review
Details
Weird edge case where we treated Default Chat Rooms like DMs for the
login
property inOptionsListUtils
when there was only one other participant in it. I think essentially we should just treat Default Chat Rooms like Multiple Participant Rooms in this case.Fixed Issues
$ #4376
Tests/QA
Tested On