-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU - Autofocus 'What's it for?' text box in details page #4263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I didn't see any react-navigation bugs either 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Just want to confirm - does the keyboard launch on all devices when this field is autofocused? I think it should, but the screenshots make it seem like it might not be the case. |
Yes they do, but I had hardware keyboard on in the simulator. |
Sounds good, thanks for confirming! |
Yes, I confirmed that too. @rushatgabhane Just in case you weren't aware, to make the software keyboard work in an iOS simulator you can go to |
Too bad we can't raise an issue on their repo 😆 |
🚀 Deployed to staging in version: 1.0.80-3🚀
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
Details
Added
autoFocus
prop toTextInput
I didn't encounter any bugs that were mentioned in this comment.
Fixed Issues
$ #4215
Tests / QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android