Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Autofocus 'What's it for?' text box in details page #4263

Merged
merged 1 commit into from
Jul 28, 2021
Merged

IOU - Autofocus 'What's it for?' text box in details page #4263

merged 1 commit into from
Jul 28, 2021

Conversation

rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Jul 28, 2021

Details

Added autoFocus prop to TextInput

I didn't encounter any bugs that were mentioned in this comment.

Fixed Issues

$ #4215

Tests / QA

  1. Sign in to New Expensify
  2. Request money to any user
  3. Enter amount and go next.
  4. Verify that 'What's it for?' text box is focused.
  5. Verify that the keyboard pops up for mobile devices.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-07-28 at 2 30 38 AM

Mobile Web

Desktop

Screen Shot 2021-07-28 at 2 52 50 AM

iOS

Screen Shot 2021-07-28 at 11 20 21 AM

Android

@rushatgabhane rushatgabhane requested a review from a team as a code owner July 28, 2021 00:13
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team July 28, 2021 00:13
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't see any react-navigation bugs either 👍

@roryabraham roryabraham merged commit 4daaf9a into Expensify:main Jul 28, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@shawnborton
Copy link
Contributor

Just want to confirm - does the keyboard launch on all devices when this field is autofocused? I think it should, but the screenshots make it seem like it might not be the case.

@rushatgabhane
Copy link
Member Author

rushatgabhane commented Jul 28, 2021

Just want to confirm - does the keyboard launch on all devices when this field is autofocused? I think it should, but the screenshots make it seem like it might not be the case.

Yes they do, but I had hardware keyboard on in the simulator.
Updated the screenshots.

@shawnborton
Copy link
Contributor

Sounds good, thanks for confirming!

@roryabraham
Copy link
Contributor

Yes, I confirmed that too. @rushatgabhane Just in case you weren't aware, to make the software keyboard work in an iOS simulator you can go to I/O -> Keyboard -> Toggle Software Keyboard or just CMD + K and it will start behaving more like a physical device. I don't know why it doesn't do that by default.

@rushatgabhane
Copy link
Member Author

I don't know why it doesn't do that by default.

Too bad we can't raise an issue on their repo 😆

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants