[Wave Collect] [Xero] Default select options #42360

mananjadhav · 2024-05-18T06:53:00Z

For Xero Integration, some of settings didn't have default option selected. If the mappings are not set, we should be selecting the first option from the data list.

Details

Fixed Issues

$ #42378
PROPOSAL:

Tests

Pre-requisite:

Workspace with Xero account with no previous data sync attempt. In case the sync is done, disconnect and setup agai.

Steps

Login with a user who already has the Xero account setup.
Go to Workspace having Xero connection -> Accounting -> Export.
Verify in Xero bank account, the first option is shown in the MenuItem. For the Demo company it's Business Bank Account.
Clicking the item should also show the first option selected.
Go to Workspace having Xero connection -> Accounting -> Advanced.
Repeat the steps 4 and 5, for Xero Bill Payment Account and Xero Invoice Collections Account.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-xero-default-option.mov

Android: mWeb Chrome

mweb-chrome-xero-default-option.mov

iOS: Native

ios-xero-default-option.mov

iOS: mWeb Safari

mweb-safari-xero-default-option.mov

MacOS: Chrome / Safari

web-xero-default-option.mov

MacOS: Desktop

desktop-xero-default-option.mov

…into xero-default-select-options

melvin-bot · 2024-05-20T19:16:40Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-05-20T19:17:07Z

You can ignore this one @ishpaul777.

@rushatgabhane @hungvu193 @lakchote This one is for default option select.

rushatgabhane · 2024-05-20T19:31:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

@lakchote LGTM

melvin-bot · 2024-05-20T21:11:53Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #42378 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

lakchote · 2024-05-21T08:07:50Z

src/pages/workspace/accounting/xero/advanced/XeroBillPaymentAccountSelectorPage.tsx

+    const xeroSelectorOptions = useMemo<SelectorType[]>(() => {
+        const isMatchFound = bankAccounts?.some(({id}) => id === reimbursementAccountID);
+
+        return (bankAccounts ?? []).map(({id, name}, index) => ({
+            value: id,
+            text: name,
+            keyForList: id,
+            isSelected: isMatchFound ? reimbursementAccountID === id : index === 0,
+        }));
+    }, [reimbursementAccountID, bankAccounts]);


This code is repeated 3 times, in 3 different files. Can you move it to an utility function?

lakchote

Left a comment

…into xero-default-select-options

OSBotify · 2024-05-30T21:54:56Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:31:26Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:57:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 4 commits May 17, 2024 23:10

fix: select first item in list

acbeb1b

fix: default select first item

89a68ba

fix: default select first item

77cedd2

Merge branch 'xero-merge-freeze' of https://github.com/Expensify/App …

1f71c18

…into xero-default-select-options

mananjadhav marked this pull request as ready for review May 20, 2024 19:16

mananjadhav requested a review from a team as a code owner May 20, 2024 19:16

melvin-bot bot requested review from ishpaul777 and removed request for a team May 20, 2024 19:16

mananjadhav changed the title ~~Xero default select options~~ [Wave Collect] [Xero] Default select options May 20, 2024

rushatgabhane approved these changes May 20, 2024

View reviewed changes

lakchote reviewed May 21, 2024

View reviewed changes

mananjadhav added 5 commits May 21, 2024 13:56

Merge branch 'xero-merge-freeze' of https://github.com/Expensify/App …

a8ee9fe

…into xero-default-select-options

refactor: move bank selection to utils

f3cbb21

refactor: replace with utils

e143cfb

refactor: replace with utils

92cd9c6

refactor: lint fixes

a66f8cb

lakchote approved these changes May 21, 2024

View reviewed changes

lakchote merged commit 1342b73 into Expensify:xero-merge-freeze May 21, 2024
15 checks passed

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

izarutskaya mentioned this pull request Jun 3, 2024

Accounting - User need no sync Xero integration after connection #42992

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-11] [Wave Collect] [Xero] The first bank account in the list is not selected by default #42378

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wave Collect] [Xero] Default select options #42360

[Wave Collect] [Xero] Default select options #42360

mananjadhav commented May 18, 2024 •

edited

Loading

melvin-bot bot commented May 20, 2024

mananjadhav commented May 20, 2024

rushatgabhane commented May 20, 2024 •

edited

Loading

rushatgabhane left a comment

melvin-bot bot commented May 20, 2024

lakchote May 21, 2024

lakchote left a comment

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

OSBotify commented Jun 4, 2024

[Wave Collect] [Xero] Default select options #42360

[Wave Collect] [Xero] Default select options #42360

Conversation

mananjadhav commented May 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 20, 2024

mananjadhav commented May 20, 2024

rushatgabhane commented May 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 20, 2024

lakchote May 21, 2024

Choose a reason for hiding this comment

lakchote left a comment

Choose a reason for hiding this comment

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

OSBotify commented Jun 4, 2024

mananjadhav commented May 18, 2024 •

edited

Loading

rushatgabhane commented May 20, 2024 •

edited

Loading