password match error fixed

[ABee-Tech]

Details

Check out the comments in this issue for more detail: #3976

Fixed Issues

$ #3976

Tests

1. Enter email on the first screen after you have downloaded the app.
2. The magic link is sent to your email.
3. Tap on the magic link to open it in Expensify.cash app.
4. Tap on confirm password field.
5. Type anything and tap on enter your new password field.
6. Type password as directed as at least 8 characters, 1 capital letter, 1 lowercase letter, 1 number.
7. Tap on confirm the password field and clear all the text on the "Confirm Password" field then the screen will not become blank again.

QA Steps

Same as tests

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Android

After.1.mp4

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[ABee-Tech]

I have read the CLA Document and I hereby sign the CLA

[ABee-Tech]

@iwiznia I have done changes. Please review the changes.

[iwiznia]

Seems you have linting errors, can you fix those? Also keep an eye on the tests that are still running.

[ABee-Tech]

I didn't get what exactly the lint is telling about the trailing comma. Can you clarify so that I can push it?

[ABee-Tech]

Okay, I got it I will fix the lint. It is searching comma like this:

    showPasswordMatchError() {
        return Boolean(
            !this.doPasswordsMatch()
            && this.state.shouldShowPasswordConfirmError
            && this.state.confirmNewPassword,
        );
    }

[iwiznia]

Yeah, but it should not be needed... I think the linter is making a mistake.

[iwiznia]

Anyway, go ahead and add it.

[ABee-Tech]

Ohh, I added it. Is that ok?

[iwiznia]

Yeah yeah, we can figure out what's wrong with the linter later (if we care)

[ABee-Tech]

Okay, thank you.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.79-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.80-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅