Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for sync stages #41490

Merged
merged 5 commits into from
May 10, 2024
Merged

Add translations for sync stages #41490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a585c77
add missing xero sync stages
lakchote May 2, 2024
391dd13
add xero sync keys to display meaningful messages
lakchote May 2, 2024
7efeff0
add spanish DeepL translations
lakchote May 7, 2024
8cc2391
fix spanish translations
lakchote May 7, 2024
5e5650f
fix prettier
lakchote May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1730,6 +1730,8 @@ const CONST = {
XERO_SYNC_IMPORT_CUSTOMERS: 'xeroSyncImportCustomers',
XERO_SYNC_IMPORT_BANK_ACCOUNTS: 'xeroSyncImportBankAccounts',
XERO_SYNC_IMPORT_TAX_RATES: 'xeroSyncImportTaxRates',
XERO_CHECK_CONNECTION: 'xeroCheckConnection',
XERO_SYNC_TITLE: 'xeroSyncTitle',
},
},
ACCESS_VARIANTS: {
Expand Down
22 changes: 22 additions & 0 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2293,6 +2293,28 @@ export default {
return 'Updating people list';
case 'quickbooksOnlineSyncApplyClassesLocations':
return 'Updating report fields';
case 'xeroSyncImportChartOfAccounts':
Copy link
Member

@rushatgabhane rushatgabhane May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lakchote we need to add all the translations in spanish too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I thought about it at first and then because of having to swich tasks, forgot about it.

I've asked for spanish translations and will update PR as soon as I have them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for spanish translations here for reference (for internal employees)

return 'Syncing chart of accounts';
case 'xeroSyncImportCategories':
return 'Syncing categories';
case 'xeroSyncImportCustomers':
return 'Syncing customers';
case 'xeroSyncXeroReimbursedReports':
return 'Marking Expensify reports as reimbursed';
case 'xeroSyncExpensifyReimbursedReports':
return 'Marking Xero bills and invoices as paid';
case 'xeroSyncImportTrackingCategories':
return 'Syncing tracking categories';
case 'xeroSyncImportBankAccounts':
return 'Syncing bank accounts';
case 'xeroSyncImportTaxRates':
return 'Syncing tax rates';
case 'xeroCheckConnection':
return 'Checking Xero connection';
case 'xeroSyncTitle':
return 'Synchronizing Xero data';
case 'xeroSyncStep':
return 'Loading data';
default: {
return `Translation missing for stage: ${stage}`;
}
Expand Down
22 changes: 22 additions & 0 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2294,6 +2294,28 @@ export default {
return 'Actualizando empleados';
case 'quickbooksOnlineSyncApplyClassesLocations':
return 'Actualizando clases';
case 'xeroSyncImportChartOfAccounts':
return 'Sincronizando plan de cuentas';
case 'xeroSyncImportCategories':
return 'Sincronizando categorias';
case 'xeroSyncImportCustomers':
return 'Sincronizando clientes';
case 'xeroSyncXeroReimbursedReports':
return 'Marcar los informes de Expensify como reembolsados';
case 'xeroSyncExpensifyReimbursedReports':
return 'Marcar facturas y recibos de Xero como pagados';
case 'xeroSyncImportTrackingCategories':
return 'Sincronizando categorías de seguimiento';
case 'xeroSyncImportBankAccounts':
return 'Sincronizando cuentas bancarias';
case 'xeroSyncImportTaxRates':
return 'Sincronizando las tasas de impuesto';
case 'xeroCheckConnection':
return 'Comprobando la conexión a Xero';
case 'xeroSyncTitle':
return 'Sincronizando los datos de Xero';
case 'xeroSyncStep':
return 'Cargando datos';
default: {
return `Translation missing for stage: ${stage}`;
}
Expand Down
Loading