Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix incorect staging url #4037

Merged
merged 1 commit into from
Jul 14, 2021
Merged

[No QA] Fix incorect staging url #4037

merged 1 commit into from
Jul 14, 2021

Conversation

rafecolton
Copy link
Member

@rafecolton rafecolton commented Jul 14, 2021 •
edited
Loading

Details

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/161422

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@rafecolton rafecolton requested review from Jag96 and roryabraham July 14, 2021 18:16
@rafecolton rafecolton self-assigned this Jul 14, 2021
@rafecolton rafecolton requested a review from a team as a code owner July 14, 2021 18:16
@rafecolton rafecolton changed the title Fix incorect staging url [No QA] Fix incorect staging url Jul 14, 2021
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team July 14, 2021 18:16
@roryabraham
Copy link
Contributor

Going to merge this to push the prod deploy along.

@roryabraham roryabraham merged commit 9da2ab6 into main Jul 14, 2021
@roryabraham roryabraham deleted the follow-up branch July 14, 2021 18:31
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
@roryabraham
Merge pull request #4037 from Expensify/follow-up
b5cb694 
[No QA] Fix incorect staging url

(cherry picked from commit 9da2ab6)
This was referenced Jul 14, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@Jag96 Jag96 Awaiting requested review from Jag96

@Luke9389 Luke9389 Awaiting requested review from Luke9389

Assignees

@rafecolton rafecolton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafecolton @OSBotify @roryabraham