Infinite loading on video preview before sending video #39755

ikevin127 · 2024-04-05T17:33:54Z

Details

Due to a WebKit browser engine limitation which does not allow us to skip the first milisecond of the video blob programatically via #t= (time fragment), we removed that functionality specifically for if Browser.isMobileWebKit() is true which means only for iOS: mWeb.

Fixed Issues

$ #39078
PROPOSAL: #39078 (comment)

Tests

Go to any chat.
Tap on "+" button.
Select "Add attachment" and any other option.
Select a video.
Verify there's no more infinite loading of video on iOS: mWeb and the video preview is transparent.
The behaviour on all other platforms should be: no infinite loading and additionally the video preview will show as expected.

Verify that no errors appear in the JS console

Offline tests

TLDR: same as Tests.

Go to any chat.
Tap on "+" button.
Select "Add attachment" and any other option.
Select a video.
While offline: there will always be an infinite loading indicator, on all platforms.

QA Steps

TLDR: same as Tests.

Go to any chat.
Tap on "+" button.
Select "Add attachment" and any other option.
Select a video.
Verify there's no more infinite loading of video on iOS: mWeb and the video preview is transparent.
The behaviour on all other platforms should be: no infinite loading and additionally the video preview will show as expected.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: Native

ios.MP4

iOS: mWeb Safari

ios-mweb.MP4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-04-05T17:33:59Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2024-04-08T11:55:04Z

@ikevin127 I just tested your PR on both Safari & Chrome on a physical iPhone – it works fine. Can you reliably reproduce the issue you were talking about here?

ikevin127 · 2024-05-04T19:45:31Z

src/libs/Browser/index.website.ts

@@ -101,4 +109,4 @@ const openRouteInDesktopApp: OpenRouteInDesktopApp = (shortLivedAuthToken = '',
    }
 };

-export {getBrowser, isMobile, isMobileSafari, isSafari, isMobileChrome, openRouteInDesktopApp};
+export {getBrowser, isMobile, isMobileSafari, isMobileWebKit, isSafari, isMobileChrome, openRouteInDesktopApp};


Context:

Reviewer asked whether we can use existing isMobileSafari.

Nope, we need to cover all iOS: mWeb WebKit-based browser engines, this includes iOS: Chrome, Firefox and ay other browsers which are forced by Apple to use the WebKit engine.

Therefore we need to cover for all of them, otherwise the infinite loading would appear on Chrome / Firefox / other browsers one can install on their iPhone.

ishpaul777 · 2024-05-04T19:48:34Z

haha.. realized that deleted comment 😄

ishpaul777 · 2024-05-04T19:55:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

not affected platform

Android: mWeb Chrome

not a affected platform

iOS: Native

not a affected platform

iOS: mWeb Safari

RPReplay_Final1714852761.mov

RPReplay_Final1714852880.mov

MacOS: Chrome / Safari

not a affected platform

MacOS: Desktop

not a affected platform

OSBotify · 2024-05-06T14:51:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kbecciv · 2024-05-07T18:42:08Z

@ikevin127 @amyevans I'm a bit confused about the Offline steps. It says there should be 'no infinite loading,' but when following the steps offline, there's still an infinite loading screen. Is this expected behavior?

Recording.856.mp4

ikevin127 · 2024-05-07T18:53:00Z

@kbecciv My bad, I just copy & pasted the same tests from online without checking. I corrected the offline test just now!

Note: It is expected behaviour that we see the infinite loading while offline since this was the behaviour before the PR was merged (can be verified on production).

OSBotify · 2024-05-09T02:09:55Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 requested a review from a team as a code owner April 5, 2024 17:33

melvin-bot bot requested review from paultsimura and removed request for a team April 5, 2024 17:33

ikevin127 mentioned this pull request Apr 5, 2024

[HOLD for Payment 2024-05-15][$500] mWeb - Chat - Infinite loading on video preview before sending video #39078

Closed

6 tasks

This comment was marked as outdated.

Sign in to view

Infinite loading on video preview before sending vide

43c7f57

ikevin127 force-pushed the fix/39078 branch from 6fc0b72 to 43c7f57 Compare May 2, 2024 20:17

ikevin127 commented May 4, 2024

View reviewed changes

This comment was marked as off-topic.

Sign in to view

ishpaul777 approved these changes May 4, 2024

View reviewed changes

melvin-bot bot requested a review from amyevans May 4, 2024 20:06

amyevans approved these changes May 6, 2024

View reviewed changes

amyevans merged commit c496ce6 into Expensify:main May 6, 2024
18 of 20 checks passed

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Infinite loading on video preview before sending video #39755

Infinite loading on video preview before sending video #39755

ikevin127 commented Apr 5, 2024 •

edited

Loading

melvin-bot bot commented Apr 5, 2024

paultsimura commented Apr 8, 2024

This comment was marked as outdated.

ikevin127 May 4, 2024 •

edited

Loading

ishpaul777 commented May 4, 2024 •

edited

Loading

This comment was marked as off-topic.

ishpaul777 commented May 4, 2024 •

edited

Loading

OSBotify commented May 6, 2024

kbecciv commented May 7, 2024

ikevin127 commented May 7, 2024

OSBotify commented May 9, 2024

Infinite loading on video preview before sending video #39755

Infinite loading on video preview before sending video #39755

Conversation

ikevin127 commented Apr 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 5, 2024

paultsimura commented Apr 8, 2024

This comment was marked as outdated.

ikevin127 May 4, 2024 • edited Loading

Choose a reason for hiding this comment

ishpaul777 commented May 4, 2024 • edited Loading

This comment was marked as off-topic.

ishpaul777 commented May 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented May 6, 2024

kbecciv commented May 7, 2024

ikevin127 commented May 7, 2024

OSBotify commented May 9, 2024

ikevin127 commented Apr 5, 2024 •

edited

Loading

ikevin127 May 4, 2024 •

edited

Loading

ishpaul777 commented May 4, 2024 •

edited

Loading

ishpaul777 commented May 4, 2024 •

edited

Loading