Code

Fix blank area after loading pdf#38010

Code

Merged

yuwenmemon merged 60 commits intoExpensify:mainExpensify/App:mainfrom ishpaul777:fix-blankArea-after-loading-pdfishpaul777/App:fix-blankArea-after-loading-pdfCopy head branch name to clipboardMay 15, 2024

+158-64

Commits

Commits on Mar 8, 2024

• add POC for fallingback to default attachment view when pdf fails to load

  ishpaul777

  committed
  ffb21f1

  Copy full SHA for ffb21f1

• adds chnages for attachement view

  ishpaul777

  committed
  bde48fa

  Copy full SHA for bde48fa

• Merge branch 'fix/blankArea-for-corruptedPDF' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  9323594

  Copy full SHA for 9323594

• formatting

  ishpaul777

  committed
  757661b

  Copy full SHA for 757661b

• Merge branch 'fix-blankArea-after-loading-pdf' of https://github.com/ishpaul777/App into fix-blankArea-after-loading-pdf

  ishpaul777

  committed
  c4fce87

  Copy full SHA for c4fce87

• fixes conflicts

  ishpaul777

  committed
  26c1f13

  Copy full SHA for 26c1f13

• fix conflict after merge

  ishpaul777

  committed
  36b5814

  Copy full SHA for 36b5814

Commits on Mar 13, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  f7b6cd5

  Copy full SHA for f7b6cd5

• clean up and lint fix

  ishpaul777

  committed
  75a733c

  Copy full SHA for 75a733c

Commits on Mar 15, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  1a84b64

  Copy full SHA for 1a84b64

• add POC for fallingback to default attachment view when pdf fails to load

  ishpaul777

  committed
  e2b9966

  Copy full SHA for e2b9966

• fixes missing prop

  ishpaul777

  committed
  02f26eb

  Copy full SHA for 02f26eb

• Merge branch 'fix-blankArea-after-loading-pdf' of https://github.com/ishpaul777/App into fix-blankArea-after-loading-pdf

  ishpaul777

  committed
  2d37945

  Copy full SHA for 2d37945

• remove unused import

  ishpaul777

  committed
  b4ac9a1

  Copy full SHA for b4ac9a1

• change variable name

  ishpaul777

  committed
  0372601

  Copy full SHA for 0372601

• fixes lint

  ishpaul777

  committed
  a20811a

  Copy full SHA for a20811a

• use correct conditional and use js docs for props

  ishpaul777

  committed
  3ace4d3

  Copy full SHA for 3ace4d3

• prettier diffs

  ishpaul777

  committed
  830a392

  Copy full SHA for 830a392

• Update src/components/Attachments/AttachmentCarousel/CarouselItem.js

  ishpaul777

  authored
  3813026

  Copy full SHA for 3813026

• remove unused styles

  ishpaul777

  authored
  a8cfafe

  Copy full SHA for a8cfafe

Commits on Mar 16, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  5199de9

  Copy full SHA for 5199de9

Commits on Mar 19, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  ccbcfe0

  Copy full SHA for ccbcfe0

• remove error label styles

  ishpaul777

  committed
  a45f6f0

  Copy full SHA for a45f6f0

• Merge branch 'fix-blankArea-after-loading-pdf' of https://github.com/ishpaul777/App into fix-blankArea-after-loading-pdf

  ishpaul777

  committed
  1f489cf

  Copy full SHA for 1f489cf

Commits on Mar 20, 2024

• Merge branch 'main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  cb7ba78

  Copy full SHA for cb7ba78

Commits on Mar 28, 2024

• Merge branch 'main' into fix-blankArea-after-loading-pdf

  ishpaul777

  committed
  81efdb2

  Copy full SHA for 81efdb2

• fix conflicts

  ishpaul777

  committed
  32f3503

  Copy full SHA for 32f3503

• fix lint

  ishpaul777

  committed
  1c814c5

  Copy full SHA for 1c814c5

• fallback to defaultview component

  ishpaul777

  committed
  302fdba

  Copy full SHA for 302fdba

• fix prop pass

  ishpaul777

  committed
  3b51760

  Copy full SHA for 3b51760

• prettier diffs

  ishpaul777

  committed
  7d5d22a

  Copy full SHA for 7d5d22a

Commits on Mar 29, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  088813d

  Copy full SHA for 088813d

• remove renderfallbackview prop

  ishpaul777

  committed
  0af56c6

  Copy full SHA for 0af56c6

• fix the comment for the prop

  ishpaul777

  committed
  b18b06a

  Copy full SHA for b18b06a

• fixes loading for pdf on web

  ishpaul777

  committed
  6436ddb

  Copy full SHA for 6436ddb

• fixes proptype warning

  ishpaul777

  committed
  359c54d

  Copy full SHA for 359c54d

• prettier diffs

  ishpaul777

  committed
  691e2a8

  Copy full SHA for 691e2a8

Commits on Apr 2, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  2b1bff7

  Copy full SHA for 2b1bff7

• adds onError prop in react-fast-pdf

  ishpaul777

  committed
  9bd4c96

  Copy full SHA for 9bd4c96

Commits on Apr 6, 2024

• Merge branch 'main' into fix-blankArea-after-loading-pdf

  ishpaul777

  committed
  7003564

  Copy full SHA for 7003564

• resolve conflicts

  ishpaul777

  committed
  e714b2f

  Copy full SHA for e714b2f

• code formatting

  ishpaul777

  committed
  15eea96

  Copy full SHA for 15eea96

• remove unnecessary change

  ishpaul777

  committed
  7a9565a

  Copy full SHA for 7a9565a

• fix type checks

  ishpaul777

  committed
  6912979

  Copy full SHA for 6912979

• lint code

  ishpaul777

  committed
  917095c

  Copy full SHA for 917095c

• prettier diffs

  ishpaul777

  committed
  c968147

  Copy full SHA for c968147

• resolve lint failure

  ishpaul777

  committed
  cadf1f1

  Copy full SHA for cadf1f1

• prettier diffs

  ishpaul777

  committed
  54eb295

  Copy full SHA for 54eb295

Commits on Apr 11, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  3044ee9

  Copy full SHA for 3044ee9

• remove unnecessary styles

  ishpaul777

  committed
  9c1527b

  Copy full SHA for 9c1527b

Commits on Apr 16, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  3c871f1

  Copy full SHA for 3c871f1

Commits on May 3, 2024

• merge main

  ishpaul777

  committed
  0338f8d

  Copy full SHA for 0338f8d

• prettier diffs

  ishpaul777

  committed
  838e465

  Copy full SHA for 838e465

Commits on May 13, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  17ed872

  Copy full SHA for 17ed872

• fixes preview not centered in carousel

  ishpaul777

  committed
  3763d32

  Copy full SHA for 3763d32

• fix loading component

  ishpaul777

  committed
  da41661

  Copy full SHA for da41661

• prettier

  ishpaul777

  committed
  c134239

  Copy full SHA for c134239

Commits on May 15, 2024

• Merge branch 'Expensify:main' into fix-blankArea-after-loading-pdf

  ishpaul777

  authored
  9c1b2c4

  Copy full SHA for 9c1b2c4

• Add-empty-newlines

  Show description for e1d69f6
  

  ishpaul777

  and

  yuwenmemon

  authored
  e1d69f6

  Copy full SHA for e1d69f6

• adds requested changes

  ishpaul777

  committed
  569b7c1

  Copy full SHA for 569b7c1