[Card Settings] fix card lost/damaged flow #34098

JKobrynski · 2024-01-08T13:42:27Z

Details

Fixed Issues

$ #33514
PROPOSAL: N/A

Tests

Add the following effect to WalletPage.js:

    useEffect(() => {
        if (cardList[234523452345]) {
            return;
        }
        // eslint-disable-next-line rulesdir/prefer-actions-set-data
        window.Onyx.merge(`cardList`, {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
        });
    }, [cardList]);

Log into the app
Navigate to the Settings page
Navigate to the Wallet page
Click on Expensify Card in the Assigned cards section
Click on the Report physical card loss / damage button
Test the flow with both options (lost/stolen and damaged)

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-compressed.webm

Android: mWeb Chrome

chrome-compressed.webm

iOS: Native

ios-compressed.mp4

iOS: mWeb Safari

safari-compressed.mp4

MacOS: Chrome / Safari

web-compressed.mov

MacOS: Desktop

desktop-compressed.mov

melvin-bot · 2024-01-09T09:16:42Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pac-guerreiro

LGTM

hoangzinh · 2024-01-10T16:27:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-11.at.06.15.51.android.mov

Android: mWeb Chrome

Screen.Recording.2024-01-11.at.05.59.05.android.chrome.mov

iOS: Native

Screen.Recording.2024-01-11.at.06.01.09.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-01-11.at.06.00.29.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-11.at.05.52.33.-.web.mov

MacOS: Desktop

Screen.Recording.2024-01-11.at.05.54.37.desktop.mov

hoangzinh · 2024-01-10T22:50:39Z

src/languages/es.ts

@@ -2501,9 +2501,11 @@ export default {
        cardDamaged: 'Mi tarjeta está dañada',
        cardLostOrStolen: 'He perdido o me han robado la tarjeta',
        confirmAddressTitle: 'Confirma que la dirección que aparece a continuación es a la que deseas que te enviemos tu nueva tarjeta.',
-        currentCardInfo: 'La tarjeta actual se desactivará permanentemente en cuanto se realice el pedido. La mayoría de las tarjetas llegan en unos pocos días laborables.',
+        cardDamagedInfo: 'Su nueva tarjeta llegará en 2-3 días laborables, y su tarjeta actual seguirá funcionando hasta que active la nueva.',


Just wanna double check, where did you get those copies in Spain?

I got them from deepl, I will ask on Slack to confirm they're correct 😄

Here is the question!

it looks like we got a copy in Spain, didn't we?

Right, I updated it

hoangzinh · 2024-01-10T22:51:31Z

src/pages/settings/Wallet/ReportCardLostPage.js

 /** Options for reason selector */
 const OPTIONS = [
    {
-        key: 'damaged',
+        key: OPTIONS_LABELS.DAMAGED,


Is it OPTIONS_KEYS or OPTIONS_LABELS?

Changed it 😄

grgia

As part of this PR, could you fix the capitalization of cardID here?

App/src/libs/actions/Card.ts

Lines 95 to 98 in 4de7a5e

    
           const parameters: RequestReplacementExpensifyCardParams = { 
        
               cardId, 
        
               reason, 
        
           };

JKobrynski · 2024-01-15T08:20:56Z

@grgia done!

OSBotify · 2024-01-17T00:00:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mvtglobally · 2024-01-17T04:48:04Z

@grgia @JKobrynski @hoangzinh Are we able to QA this in staging without the code snippet?
Or this will require real CC to validate?

hoangzinh · 2024-01-17T14:47:54Z

@JKobrynski could you check @mvtglobally question above? I guess we need a real CC if we don't use code snippet, don't we?

OSBotify · 2024-01-18T03:13:20Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

JKobrynski added 2 commits January 8, 2024 13:57

change text info and button labels for damaged and stolen flows

1341dbd

remove useEffect with mock

edf43f6

JKobrynski marked this pull request as ready for review January 9, 2024 09:16

JKobrynski requested a review from a team as a code owner January 9, 2024 09:16

melvin-bot bot requested review from hoangzinh and removed request for a team January 9, 2024 09:16

JKobrynski mentioned this pull request Jan 9, 2024

[HOLD for payment 2024-01-25] [Card Settings] 🐛 Damaged flow is saying it will immediately cancel the card, rather than saying it will continue to work until the new card is activated #33514

Closed

pac-guerreiro approved these changes Jan 9, 2024

View reviewed changes

grgia self-requested a review January 10, 2024 21:10

hoangzinh reviewed Jan 10, 2024

View reviewed changes

JKobrynski added 2 commits January 11, 2024 09:18

rename OPTIONS_LABELS to OPTIONS_KEYS

112a743

change spanish translations

d04cec9

JKobrynski requested a review from hoangzinh January 12, 2024 10:00

hoangzinh approved these changes Jan 12, 2024

View reviewed changes

grgia reviewed Jan 12, 2024

View reviewed changes

JKobrynski added 2 commits January 15, 2024 09:18

Merge branch 'main' into fixCardDamagedFlow

f49bef7

fix cardId capitalization in Card.ts

2a9a11b

JKobrynski requested a review from grgia January 15, 2024 08:21

grgia approved these changes Jan 16, 2024

View reviewed changes

grgia merged commit 7c27f51 into Expensify:main Jan 16, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 17, 2024

Deploy Checklist: New Expensify 2024-01-17 #34621

Closed

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Card Settings] fix card lost/damaged flow #34098

[Card Settings] fix card lost/damaged flow #34098

JKobrynski commented Jan 8, 2024 •

edited

Loading

melvin-bot bot commented Jan 9, 2024

pac-guerreiro left a comment

hoangzinh commented Jan 10, 2024 •

edited

Loading

hoangzinh Jan 10, 2024

JKobrynski Jan 11, 2024

JKobrynski Jan 11, 2024

hoangzinh Jan 12, 2024

JKobrynski Jan 12, 2024

hoangzinh Jan 10, 2024

JKobrynski Jan 11, 2024

grgia left a comment

JKobrynski commented Jan 15, 2024

OSBotify commented Jan 17, 2024

mvtglobally commented Jan 17, 2024

hoangzinh commented Jan 17, 2024

OSBotify commented Jan 18, 2024

	const parameters: RequestReplacementExpensifyCardParams = {
	cardId,
	reason,
	};

[Card Settings] fix card lost/damaged flow #34098

[Card Settings] fix card lost/damaged flow #34098

Conversation

JKobrynski commented Jan 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 9, 2024

pac-guerreiro left a comment

Choose a reason for hiding this comment

hoangzinh commented Jan 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh Jan 10, 2024

Choose a reason for hiding this comment

JKobrynski Jan 11, 2024

Choose a reason for hiding this comment

JKobrynski Jan 11, 2024

Choose a reason for hiding this comment

hoangzinh Jan 12, 2024

Choose a reason for hiding this comment

JKobrynski Jan 12, 2024

Choose a reason for hiding this comment

hoangzinh Jan 10, 2024

Choose a reason for hiding this comment

JKobrynski Jan 11, 2024

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

JKobrynski commented Jan 15, 2024

OSBotify commented Jan 17, 2024

mvtglobally commented Jan 17, 2024

hoangzinh commented Jan 17, 2024

OSBotify commented Jan 18, 2024

JKobrynski commented Jan 8, 2024 •

edited

Loading

hoangzinh commented Jan 10, 2024 •

edited

Loading