-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] [NoQA] Lock version of the cloudflare package #33720
Conversation
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…sion [CP Staging] [NoQA] Lock version of the cloudflare package (cherry picked from commit 1888bd2)
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.18-8 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀
|
For posterity, we created an upstream issue to inform the maintainers of this regression: https://github.com/cloudflare/python-cloudflare/issues/179
You can track that issue if you want to see if we can remove this change and use an up-to-date version of the cloudflare cli again in the future
Details
Use previous version of the cloudflare package which worked for us before until we find the real fix for the cache purge issue with latest package version
Fixed Issues
N/A
Tests
n/a
Offline tests
n/a
QA Steps
n/a
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
N/A
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop