Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace categories changelog #33253

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Replace categories changelog #33253

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c01d620
adding new policy changelog
rlinoz Dec 12, 2023
37f0e08
Merge remote-tracking branch 'origin/main' into rodrigo-replace-categ…
rlinoz Dec 14, 2023
7d748aa
Merge remote-tracking branch 'origin/main' into rodrigo-replace-categ…
rlinoz Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,7 @@ const CONST = {
INDIVIDUAL_BUDGET_NOTIFICATION: 'POLICYCHANGELOG_INDIVIDUAL_BUDGET_NOTIFICATION',
INVITE_TO_ROOM: 'POLICYCHANGELOG_INVITETOROOM',
REMOVE_FROM_ROOM: 'POLICYCHANGELOG_REMOVEFROMROOM',
REPLACE_CATEGORIES: 'POLICYCHANGELOG_REPLACE_CATEGORIES',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this constant have any uses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used here with the spread operator, if this constant is not here this action type is not shown in the chat.

App/src/pages/home/report/ReportActionItem.js

Line 445 in aa1d87c

..._.values(CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's tricky. So we never refer to it TypeScript-wise. Thank you for clarification!

SET_AUTOREIMBURSEMENT: 'POLICYCHANGELOG_SET_AUTOREIMBURSEMENT',
SET_AUTO_JOIN: 'POLICYCHANGELOG_SET_AUTO_JOIN',
SET_CATEGORY_NAME: 'POLICYCHANGELOG_SET_CATEGORY_NAME',
Expand Down
Loading