Adds ReceiptEmptyState Component and adds new component to MoneyRequestView #31029

cdanwards · 2023-11-07T20:35:19Z

Details

Fixed Issues

This is the second PR for this issue. It adds the new ReceiptEmptyState component and also adds it to the MoneyRequestView.

Tests

Navigate to a Money Request that does not contain a receipt attached
Verify that the ReceiptEmptyState component is shown
Within the MoneyRequestView set hasErrors to true
Verify that the ReceiptEmptyState component has a red border
Tap the ReceiptEmptyState component
Upload an image via the Receipt Selector and after completion, verify that the ReceiptEmptyState component is no longer shown on the Money Request View

Offline tests

Navigate to a Money Request that does not contain a receipt attached
Verify that the ReceiptEmptyState component is shown
Within the MoneyRequestView set hasErrors to true
Verify that the ReceiptEmptyState component has a red border
Tap the ReceiptEmptyState component
Upload an image via the Receipt Selector and after completion, verify that the ReceiptEmptyState component is no longer shown on the Money Request View

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Anroid_receipt.mov

Android: mWeb Chrome

Photo_Flow_Android_mWeb_480.mov

iOS: Native

iOS_receipt_1080.mov

iOS: mWeb Safari

Trimmed_iOS_photo_flow_720.mov

MacOS: Chrome / Safari

Web_receipt.mov

MacOS: Desktop

desktop_receipt.mov

melvin-bot · 2023-11-09T14:27:53Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/ReceiptEmptyState.js

src/components/ReportActionItem/MoneyRequestView.js

src/components/ReceiptEmptyState.js

Co-authored-by: Carlos Alvarez <[email protected]>

pecanoro · 2023-11-09T22:04:44Z

Let's see if puller bear gets us a c+ to review it

pecanoro · 2023-11-09T22:05:14Z

@cdanwards It seems we are missing screenshots in some platforms btw!

pecanoro · 2023-11-10T15:13:39Z

Ok, it seems puller bear is not going to work so I will ask for a C+ in the channel.

src/components/ReceiptEmptyState.js

parasharrajat · 2023-11-10T15:52:26Z

BUG: The empty area should not be clickable.

Screen.Recording.2023-11-10.at.9.21.04.PM.mov

parasharrajat

⬆️

pecanoro · 2023-11-14T14:57:13Z

@parasharrajat That does not happen on production right now, right?

@cead22 Is the above expected? When testing the current behavior, it does not show the image placeholder if the request has no receipt at all so I am not sure if we want that or not.

cdanwards · 2023-11-14T19:14:02Z

When testing the current behavior, it does not show the image placeholder if the request has no receipt at all so I am not sure if we want that or not.

@pecanoro following up on this comment. Is there more info you can provide around this? Are the betas set to allow you to use violations?

parasharrajat · 2023-11-14T19:53:23Z

That does not happen on production right now, right?

The image placeholder is only added on this PR and is not visible on prod.

cead22 · 2023-11-14T20:26:30Z

Good catch, in the issue I suggested the following

if hasReceipt is false and permissions.canUseViolations() is true we show the ReceiptEmptyState component

But we should only show this receipt empty state if the money request can be edited, and it looks like we can use canEdit for that. How does that sound?

parasharrajat · 2023-11-14T20:35:58Z

Probably, canEdit && !isSettled

cead22 · 2023-11-14T21:50:35Z

That works, but let's not block on this if this receipt empty state is only showing for the case in question for users on the beta.

I'll check with design to see if we should show a different image, or the same image with gray/secondary colors, or something else

parasharrajat · 2023-11-15T06:14:56Z

Ok. That would be the last change.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-11-15T14:37:54Z

🎯 @parasharrajat, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #31370.

OSBotify · 2023-11-15T17:21:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2023-11-15T21:40:43Z

@cdanwards @parasharrajat Could you help with the following in the QA steps?

Set the Betas.canUseViolations to true
Within the MoneyRequestView set hasErrors to true

cead22 · 2023-11-16T01:05:35Z

Set the Betas.canUseViolations to true

@kavimuru for this, just use an email address @applause.expensifail.com since that domain is on all betas

Within the MoneyRequestView set hasErrors to true

Verify that the ReceiptEmptyState component has a red border

You can skip these two steps actually

cead22 · 2023-11-16T01:42:59Z

I approved but meant to test -- I shouldn't have approved, but testing isn't working for me. It looks like Permissions.canUseViolations isn't defined in src/components/ReportActionItem/MoneyRequestView.js, because we're not importing it. @cdanwards can you confirm and fix please, and add tests covering the case of a user on the beta, and a user not on the beta?

cead22 · 2023-11-16T01:46:37Z

Let's also get Design's eyes on the border for this new component, as it looks a little bit too thick to me

situchan · 2023-11-16T06:13:46Z

src/components/ReportActionItem/MoneyRequestView.js

@@ -176,6 +177,12 @@ function MoneyRequestView({report, betas, parentReport, policyCategories, should
                        </View>
                    </OfflineWithFeedback>
                )}
+                {!hasReceipt && canEdit && !isSettled && Permissions.canUseViolations() && (


This caused regressions:

[HOLD for payment 2023-11-29] [HOLD for payment 2023-11-27] IOU - App is crashed after request money and clicking on IOU detail #31407

[HOLD for payment 2023-11-29] [HOLD for payment 2023-11-27] Delete receipt - App crashed if Delete receipt form IOU #31418

Permissions is not imported. Anyone please fix these deploy blockers?

parasharrajat · 2023-11-16T07:24:45Z

Looks like it was removed during the merge commit. why didn't it throw a lint warning?

parasharrajat · 2023-11-16T07:36:41Z

Created a PR to fix this small mistake #31420

MonilBhavsar · 2023-11-16T09:42:21Z

Looks like it was removed during the merge commit. why didn't it throw a lint warning?

Agree, let's create a new issue for this. It should throw in such cases

cdanwards · 2023-11-16T14:52:54Z

Thanks @parasharrajat. Sorry @cead22 for that oversight.

OSBotify · 2023-11-20T13:40:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 · 2024-01-29T17:52:35Z

src/components/ReportActionItem/MoneyRequestView.js

@@ -176,6 +177,12 @@ function MoneyRequestView({report, betas, parentReport, policyCategories, should
                        </View>
                    </OfflineWithFeedback>
                )}
+                {!hasReceipt && canEdit && !isSettled && Permissions.canUseViolations() && (
+                    <ReceiptEmptyState
+                        hasError={hasErrors}


@cdanwards I have a question. Is the hasErrors always false in this line?

cdanwards added 5 commits November 7, 2023 12:16

Add SVG

40f0fec

Adds ReceiptEmptyState Component

561c354

Adds EmptyStateReceipt to MoneyRequestView

d8ededb

prettier

6709c4d

Removed extra SVG and updated fill color

dfa86a0

cdanwards marked this pull request as ready for review November 9, 2023 14:27

cdanwards requested a review from a team as a code owner November 9, 2023 14:27

melvin-bot bot requested review from pecanoro and removed request for a team November 9, 2023 14:27

pecanoro requested changes Nov 9, 2023

View reviewed changes

src/components/ReceiptEmptyState.js Outdated Show resolved Hide resolved

cead22 requested changes Nov 9, 2023

View reviewed changes

cdanwards and others added 3 commits November 9, 2023 15:17

Update src/components/ReceiptEmptyState.js

3b7199b

Co-authored-by: Carlos Alvarez <[email protected]>

Update src/components/ReceiptEmptyState.js

3d11e23

Co-authored-by: Carlos Alvarez <[email protected]>

Updates comment for component

162572c

cdanwards requested a review from pecanoro November 9, 2023 20:29

pecanoro previously approved these changes Nov 9, 2023

View reviewed changes

pecanoro requested review from a team and removed request for a team November 9, 2023 22:05

melvin-bot bot requested review from joelbettner and removed request for a team November 10, 2023 15:06

This comment was marked as duplicate.

Sign in to view

pecanoro removed the request for review from joelbettner November 10, 2023 15:12

pecanoro requested a review from parasharrajat November 10, 2023 15:15

parasharrajat suggested changes Nov 10, 2023

View reviewed changes

src/components/ReceiptEmptyState.js Outdated Show resolved Hide resolved

parasharrajat suggested changes Nov 14, 2023

View reviewed changes

Updates from review

ad9d420

parasharrajat approved these changes Nov 15, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Nov 15, 2023

[hold for 2023-11-27] Payment issue for E/App PR#31029 #31370

Closed

cead22 approved these changes Nov 15, 2023

View reviewed changes

pecanoro approved these changes Nov 15, 2023

View reviewed changes

pecanoro merged commit 37ddb03 into Expensify:main Nov 15, 2023

dummy-1111 mentioned this pull request Nov 16, 2023

[HOLD for payment 2023-11-29] [HOLD for payment 2023-11-27] IOU - App is crashed after request money and clicking on IOU detail #31407

Closed

6 tasks

situchan reviewed Nov 16, 2023

View reviewed changes

kavimuru mentioned this pull request Nov 16, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

cdanwards deleted the cdanwards/receipt-empty-state branch November 20, 2023 14:43

dukenv0307 reviewed Jan 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds ReceiptEmptyState Component and adds new component to MoneyRequestView #31029

Adds ReceiptEmptyState Component and adds new component to MoneyRequestView #31029

cdanwards commented Nov 7, 2023 •

edited by github-actions bot

Loading

melvin-bot bot commented Nov 9, 2023

pecanoro commented Nov 9, 2023

pecanoro commented Nov 9, 2023

This comment was marked as duplicate.

pecanoro commented Nov 10, 2023

parasharrajat commented Nov 10, 2023

parasharrajat left a comment

pecanoro commented Nov 14, 2023

cdanwards commented Nov 14, 2023

parasharrajat commented Nov 14, 2023

cead22 commented Nov 14, 2023

parasharrajat commented Nov 14, 2023 •

edited

Loading

cead22 commented Nov 14, 2023

parasharrajat commented Nov 15, 2023

parasharrajat left a comment

melvin-bot bot commented Nov 15, 2023

OSBotify commented Nov 15, 2023

kavimuru commented Nov 15, 2023

cead22 commented Nov 16, 2023

cead22 commented Nov 16, 2023

cead22 commented Nov 16, 2023

situchan Nov 16, 2023

parasharrajat commented Nov 16, 2023 •

edited

Loading

parasharrajat commented Nov 16, 2023 •

edited

Loading

MonilBhavsar commented Nov 16, 2023

cdanwards commented Nov 16, 2023

OSBotify commented Nov 20, 2023

dukenv0307 Jan 29, 2024

Adds ReceiptEmptyState Component and adds new component to MoneyRequestView #31029

Adds ReceiptEmptyState Component and adds new component to MoneyRequestView #31029

Conversation

cdanwards commented Nov 7, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 9, 2023

pecanoro commented Nov 9, 2023

pecanoro commented Nov 9, 2023

This comment was marked as duplicate.

pecanoro commented Nov 10, 2023

parasharrajat commented Nov 10, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

pecanoro commented Nov 14, 2023

cdanwards commented Nov 14, 2023

parasharrajat commented Nov 14, 2023

cead22 commented Nov 14, 2023

parasharrajat commented Nov 14, 2023 • edited Loading

cead22 commented Nov 14, 2023

parasharrajat commented Nov 15, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

melvin-bot bot commented Nov 15, 2023

OSBotify commented Nov 15, 2023

kavimuru commented Nov 15, 2023

cead22 commented Nov 16, 2023

cead22 commented Nov 16, 2023

cead22 commented Nov 16, 2023

situchan Nov 16, 2023

Choose a reason for hiding this comment

parasharrajat commented Nov 16, 2023 • edited Loading

parasharrajat commented Nov 16, 2023 • edited Loading

MonilBhavsar commented Nov 16, 2023

cdanwards commented Nov 16, 2023

OSBotify commented Nov 20, 2023

dukenv0307 Jan 29, 2024

Choose a reason for hiding this comment

cdanwards commented Nov 7, 2023 •

edited by github-actions bot

Loading

parasharrajat commented Nov 14, 2023 •

edited

Loading

parasharrajat commented Nov 16, 2023 •

edited

Loading

parasharrajat commented Nov 16, 2023 •

edited

Loading