Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XOF currency not searchable by its second term #30735

Merged
merged 5 commits into from
Nov 3, 2023
Merged

XOF currency not searchable by its second term #30735

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4acd3b4
Fix XOF currency not searchable by its second term
ZhenjaHorbach Nov 1, 2023
fc2d0ea
Add trim for searchRegex
ZhenjaHorbach Nov 1, 2023
ae4c7cb
Add const for space
ZhenjaHorbach Nov 2, 2023
27b5503
Push changes after prettier
ZhenjaHorbach Nov 2, 2023
21b7746
Merge branch 'main' into xof-currency-not-searchable-by-its-second-term
ZhenjaHorbach Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/pages/iou/IOUCurrencySelection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,11 @@ function IOUCurrencySelection(props) {
};
});

const searchRegex = new RegExp(Str.escapeForRegExp(searchValue.trim()), 'i');
const filteredCurrencies = _.filter(currencyOptions, (currencyOption) => searchRegex.test(currencyOption.text) || searchRegex.test(currencyOption.currencyName));
const searchRegex = new RegExp(Str.escapeForRegExp(searchValue.trim().replace(/\s/g, ' ')), 'i');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhenjaHorbach Kindly add regex as a CONST here, if not already present.

App/src/CONST.ts

Line 1313 in 8088a7b

NON_NUMERIC: /\D/g,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point )
And I fixed it)

const filteredCurrencies = _.filter(
currencyOptions,
(currencyOption) => searchRegex.test(currencyOption.text.replace(/\s/g, ' ')) || searchRegex.test(currencyOption.currencyName.replace(/\s/g, ' ')),
);
const isEmpty = searchValue.trim() && !filteredCurrencies.length;

return {
Expand Down