Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript #30159

Merged
merged 4 commits into from
Nov 8, 2023
Merged

[No QA] [TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript #30159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ff328b
Rename getContextMenuItemStyles
BartoszGrajdek Oct 23, 2023
3d30bef
[TS migration] Migrate 'getContextMenuItemStyles' style to TypeScript
BartoszGrajdek Oct 23, 2023
f95aa4b
Rename getContextMenuItemStyles
BartoszGrajdek Oct 23, 2023
29423c8
Resolve merge conflicts
BartoszGrajdek Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/styles/getContextMenuItemStyles/index.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/styles/getContextMenuItemStyles/index.native.js
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions src/styles/getContextMenuItemStyles/index.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import styles from '@styles/styles';
import GetContextMenuItemStyle from './types';

const getContextMenuItemStyle: GetContextMenuItemStyle = () => [styles.popoverMenuItem];

export default getContextMenuItemStyle;
12 changes: 12 additions & 0 deletions src/styles/getContextMenuItemStyles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import styles from '@styles/styles';
import variables from '@styles/variables';
import GetContextMenuItemStyle from './types';

const GetContextMenuItemStyles: GetContextMenuItemStyle = (windowWidth) => {
if (windowWidth && windowWidth > variables.mobileResponsiveWidthBreakpoint) {
return [styles.popoverMenuItem, styles.contextMenuItemPopoverMaxWidth];
}
return [styles.popoverMenuItem];
};

export default GetContextMenuItemStyles;
5 changes: 5 additions & 0 deletions src/styles/getContextMenuItemStyles/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import {ViewStyle} from 'react-native';

type GetContextMenuItemStyle = (windowWidth?: number) => ViewStyle[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why windowWidth might undefined?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one usage of GetContextMenuItemStyle with an argument:

App/src/components/ContextMenuItem.js

Line 100 in 5d45f0f

style={getContextMenuItemStyles(windowWidth)}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually something that comes from TS guidelines. It was made that way to keep types consistent for native as well as other platforms. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see I missed the part where native doesn't require any arguments


export default GetContextMenuItemStyle;