-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send message - user navigates to Room tab when dragging to select e-mail from Chat tab #28240
Changes from 2 commits
c984d70
1ac59e5
c0f062b
37555f7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,3 @@ | ||
import {PanResponder} from 'react-native'; | ||
import SwipeInterceptPanResponder from '../../SwipeInterceptPanResponder'; | ||
|
||
const responder = PanResponder.create({ | ||
onMoveShouldSetPanResponder: () => true, | ||
onPanResponderTerminationRequest: () => false, | ||
}); | ||
|
||
export default responder; | ||
export default SwipeInterceptPanResponder; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the point of this file if all it does is export another file. Do we need it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My reasoning here was to try to maintain the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @puneetlath Looks like I lied. The TypeScript Checks job fails if there is no There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok got it! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import {PanResponder} from 'react-native'; | ||
|
||
const SwipeInterceptPanResponder = PanResponder.create({ | ||
onMoveShouldSetPanResponder: () => true, | ||
onPanResponderTerminationRequest: () => false, | ||
}); | ||
|
||
export default SwipeInterceptPanResponder; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,6 +93,9 @@ const propTypes = { | |
|
||
/** Set the default value to the input if there is a valid saved value */ | ||
shouldUseDefaultValue: PropTypes.bool, | ||
|
||
/** Indicate whether or not the input should prevent swipe actions in tabs */ | ||
canInterceptSwipe: PropTypes.bool, | ||
}; | ||
|
||
const defaultProps = { | ||
|
@@ -129,6 +132,7 @@ const defaultProps = { | |
icon: null, | ||
shouldUseDefaultValue: false, | ||
multiline: false, | ||
canInterceptSwipe: false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Boolean props should be prefixed with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated. Pushed a new commit. |
||
}; | ||
|
||
export {propTypes, defaultProps}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same things can be applied to
MapView/responder/index.android.ts
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The responder in
MapView/responder/index.android.ts
usesonStartShouldSetPanResponder
, notonMoveShouldSetPanResponder
, so that is different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh I didn't see that 😅