[CP Staging] Fix crash upon Request Preview open #26611

pradeepmdk · 2023-09-03T18:10:21Z

Details

Fixed Issues

$ #26585
PROPOSAL: #26585 (comment)

Tests

Launch New Expensify app
Go to workspace chat
Go to + > Request money > Distance
Create a distance request
Right after the request is created (when it shows $0.00), click on the IOU to open IOU thread and wait for a while
Relaunch New Expensify app
Go to the created distance IOU
Verify there is no crash

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.mp4

Mobile Web - Chrome

WhatsApp.Video.2023-09-03.at.11.32.44.PM.mp4

Mobile Web - Safari

WhatsApp.Video.2023-09-03.at.11.29.56.PM.mp4

Desktop

Untitled.mp4

iOS

Screen.Recording.2023-09-03.at.11.23.28.PM.mov

Android

Screen.Recording.2023-09-03.at.11.19.32.PM.mov

melvin-bot · 2023-09-03T18:10:25Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/ReportActionItem/ReportActionItemImage.js

hayata-suenaga · 2023-09-03T19:10:17Z

src/components/Image/index.native.js

@@ -18,7 +18,10 @@ function Image(props) {
    const {source, isAuthTokenRequired, session, ...rest} = props;

    let imageSource = source;
-    if (typeof source !== 'number' && isAuthTokenRequired) {
+    if (source && source.uri && typeof source.uri === 'number') {
+        imageSource = source.uri;


@parasharrajat

could you test other Image components used in App to make sure this doesn't break other parts of App? 🙇 🙇 🙇

Yeah, for sure.

src/components/ReportActionItem/ReportActionItemImage.js

Co-authored-by: Rajat Parashar <[email protected]>

src/components/Image/index.native.js

Pujan92 · 2023-09-03T20:45:37Z

src/components/Image/imagePropTypes.js

@@ -10,7 +10,7 @@ const imagePropTypes = {
    source: PropTypes.oneOfType([
        PropTypes.number,
        PropTypes.shape({
-            uri: PropTypes.string.isRequired,
+            uri: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,


isn't the uri should be always string https://reactnative.dev/docs/image#imagesource(I mean aren't we pass a direct number if required instead of wrapping in a object and assigning it to the uri)?

That was done initially but that would have required us managing the different value everywhere Image is used so I thought why don't we handle this inside Image.

Now you don't have to handle differences between platfroms for local resources. Just use {uri: localpath /resoource ID} .

Do you have any suggestions?

TBH I don't have any suggestions yet, I just found URI is a string in all places for React doc. Also strange that we are using the same pattern earlier and didn't face this issue for android. I will update in case I find something.

This will break source prop in other places also.
Please look into this urgently.
cc @parasharrajat

You should rather modify the ReceiptUtils.getThumbnailAndImageURIs function ig.

this image passes to ReportActionItemImage

Oh, I see. The resolution of this problem is more straightforward than anticipated.
@pradeepmdk @parasharrajat Allow me to fix this in #26452

ya because #26452 you are splitting the sourcePropTypes here. so we need to update to allow numbers on native.js.

IMO, it is not a bug deal. Image is a custom component and it is always better to keep the same prop format. I would prefer if we were just able to use {uri: anything} on all platforms. Less confusing.

I was going to suggest limiting the prop format to this only but that requires a bigger refactor which is unrelated to both problems we are solving(this & #26452). In short, no passing of direct require reference.

@parasharrajat I also prefer this.

hayata-suenaga · 2023-09-04T01:36:51Z

@parasharrajat @ZhenjaHorbach can either of you complete the checklist please?

situchan · 2023-09-04T04:06:44Z

While testing, I found the case where string value is passed to Image source
i.e. /095ec87d162ff529c4f1.png

And this causes propType error as source is expected to be one of number or object ({uri: ''})

Anyway, not blocker for this PR as it doesn't actually crash

situchan · 2023-09-04T04:18:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

source.uri : number
filename: undefined

Reproduced these on all platforms and confirmed no crash

hayata-suenaga · 2023-09-04T04:29:56Z

Requesting CP now... requested

OSBotify · 2023-09-04T04:35:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Fix crash upon Request Preview open (cherry picked from commit a7dfd6f)

shubham1206agra · 2023-09-04T05:31:11Z

While testing, I found the case where string value is passed to Image source i.e. /095ec87d162ff529c4f1.png

And this causes propType error as source is expected to be one of number or object ({uri: ''})

Anyway, not blocker for this PR as it doesn't actually crash

@situchan Another PR for this #26452

OSBotify · 2023-09-04T05:36:36Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-09-04T16:21:32Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T19:12:59Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-06T18:55:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pradeepmdk added 2 commits September 3, 2023 23:09

uri type case check

d34bae4

allow local image

775ecc3

pradeepmdk requested a review from a team as a code owner September 3, 2023 18:10

melvin-bot bot requested review from parasharrajat and removed request for a team September 3, 2023 18:10

ZhenjaHorbach reviewed Sep 3, 2023

View reviewed changes

src/components/ReportActionItem/ReportActionItemImage.js Outdated Show resolved Hide resolved

pradeepmdk added 2 commits September 3, 2023 23:48

fix the lint issue

f337d11

prettier fix

2605b0a

parasharrajat reviewed Sep 3, 2023

View reviewed changes

src/components/ReportActionItem/ReportActionItemImage.js Outdated Show resolved Hide resolved

parasharrajat reviewed Sep 3, 2023

View reviewed changes

src/components/ReportActionItem/ReportActionItemImage.js Outdated Show resolved Hide resolved

mountiny changed the title ~~26585-app-crash-when-opening-iou-thread~~ [CP Staging] 26585-app-crash-when-opening-iou-thread Sep 3, 2023

mountiny assigned pradeepmdk Sep 3, 2023

pradeepmdk added 2 commits September 4, 2023 00:29

update the condition

b983476

update preitter

fdff8ee

hayata-suenaga changed the title ~~[CP Staging] 26585-app-crash-when-opening-iou-thread~~ [CP Staging] Fix crash upon Request Preview open Sep 3, 2023

hayata-suenaga reviewed Sep 3, 2023

View reviewed changes

parasharrajat reviewed Sep 3, 2023

View reviewed changes

src/components/ReportActionItem/ReportActionItemImage.js Outdated Show resolved Hide resolved

Update src/components/ReportActionItem/ReportActionItemImage.js

b7728d4

Co-authored-by: Rajat Parashar <[email protected]>

parasharrajat reviewed Sep 3, 2023

View reviewed changes

src/components/Image/index.native.js Show resolved Hide resolved

update props

ad1608d

Pujan92 reviewed Sep 3, 2023

View reviewed changes

filename check

13dd7b1

situchan approved these changes Sep 4, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga September 4, 2023 04:19

hayata-suenaga approved these changes Sep 4, 2023

View reviewed changes

hayata-suenaga merged commit a7dfd6f into Expensify:main Sep 4, 2023

OSBotify pushed a commit that referenced this pull request Sep 4, 2023

Merge pull request #26611 from pradeepmdk/fix/26585-uri-should-be-string

01c6904

[CP Staging] Fix crash upon Request Preview open (cherry picked from commit a7dfd6f)

shubham1206agra mentioned this pull request Sep 4, 2023

fix image props for web #26452

Merged

58 tasks

mountiny mentioned this pull request Sep 4, 2023

Deploy Checklist: New Expensify 2023-09-01 #26539

Closed

40 tasks

melvin-bot bot mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-09-12] [HOLD for payment 2023-09-11] [$1000] [Distance] - App crashes when opening IOU thread and IOU shows a red dot #26585

Closed

6 tasks

OSBotify mentioned this pull request Sep 5, 2023

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix crash upon Request Preview open #26611

[CP Staging] Fix crash upon Request Preview open #26611

pradeepmdk commented Sep 3, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Sep 3, 2023

hayata-suenaga Sep 3, 2023 •

edited

Loading

parasharrajat Sep 3, 2023

Pujan92 Sep 3, 2023 •

edited

Loading

parasharrajat Sep 3, 2023

Pujan92 Sep 3, 2023

shubham1206agra Sep 4, 2023

shubham1206agra Sep 4, 2023

pradeepmdk Sep 4, 2023

shubham1206agra Sep 4, 2023

pradeepmdk Sep 4, 2023

parasharrajat Sep 4, 2023

pradeepmdk Sep 4, 2023

hayata-suenaga commented Sep 4, 2023

situchan commented Sep 4, 2023

situchan commented Sep 4, 2023

situchan left a comment

hayata-suenaga commented Sep 4, 2023 •

edited

Loading

OSBotify commented Sep 4, 2023

shubham1206agra commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

[CP Staging] Fix crash upon Request Preview open #26611

[CP Staging] Fix crash upon Request Preview open #26611

Conversation

pradeepmdk commented Sep 3, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 3, 2023

hayata-suenaga Sep 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pujan92 Sep 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hayata-suenaga commented Sep 4, 2023

situchan commented Sep 4, 2023

situchan commented Sep 4, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

hayata-suenaga commented Sep 4, 2023 • edited Loading

OSBotify commented Sep 4, 2023

shubham1206agra commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

pradeepmdk commented Sep 3, 2023 •

edited by mountiny

Loading

hayata-suenaga Sep 3, 2023 •

edited

Loading

Pujan92 Sep 3, 2023 •

edited

Loading

hayata-suenaga commented Sep 4, 2023 •

edited

Loading