[CP Staging] Fixing the race condition on `history.go` due to buggy queue async callbacks #25989

shubham1206agra · 2023-08-26T08:35:17Z

Reverts #25963

Details

Fixed Issues

$ #25527
$ #25626
PROPOSAL: #25527 (comment)

Tests / QA Steps

Open the app
Click CTRL+K
Click CTRL+SHIFT+K
Again click CTRL+K

Request money
Write some amount
Click on the currency symbol to change currency
Select different currency
Verify you have been naivgated back to the amount page and correct amount and currency are selected
Contine in the request money flow
On the confirmation page, select amount and chage the amount and currency
Verify this work correctly
Request the money from another user
Navigate to the expense detail
Edit the amount and currency
Verify it worked correctly

Verify that no errors appear in the JS console
Verify that the search page should be open at last

Additional Test

Open settings
CMD + K to open search
CMD+ SHIFT + K to open new group
CMD + K again to open search

Verify that no errors appear in the JS console
Verify that the search page should be open at last

Click on FAB
Request Money
On the amount page, click the currency symbol to change the currency
Select some other currency

Request money
Write some amount
Click on the currency symbol to change currency
Select different currency
Verify you have been naivgated back to the amount page and correct amount and currency are selected
Contine in the request money flow
On the confirmation page, select amount and chage the amount and currency
Verify this work correctly
Request the money from another user
Navigate to the expense detail
Edit the amount and currency
Verify it worked correctly

Verify that no errors appear in the JS console
Verify that the amount should be open at last

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-21.at.7.13.50.PM.mov

Mobile Web - Chrome

NA

Mobile Web - Safari

NA

Desktop

Screen.Recording.2023-08-24.at.9.21.04.PM.mov

iOS

NA

Android

NA

…to buggy queue async callbacks""

shubham1206agra · 2023-08-26T08:35:44Z

Do not merge before #25988

…vigation-native-fix

melvin-bot · 2023-08-31T16:10:12Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-08-31T16:10:17Z

Please retest the flow

…vigation-native-fix

shubham1206agra · 2023-09-01T05:43:42Z

Looks like flow working properly now

mountiny · 2023-09-01T12:48:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

25989web.mp4

Mobile Web - Chrome

N/A

Mobile Web - Safari

25989safari.mp4

Desktop

Author listed

iOS

N/A

Android

N/A

mountiny

We have confirmed this is fixing a serious bug with currency list not working so I would like to get this CPed

OSBotify · 2023-09-01T12:56:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-01T13:08:15Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/25989/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/25989/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/25989/NewExpensify.dmg	https://25989.pr-testing.expensify.com

…866-react-navigation-native-fix [CP Staging] Fixing the race condition on `history.go` due to buggy queue async callbacks (cherry picked from commit 12a6f87)

OSBotify · 2023-09-01T15:42:50Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.61-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-01T23:09:11Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Revert "[NoQA] Revert "Fixing the race condition on history.go due …

4a6a58b

…to buggy queue async callbacks""

shubham1206agra mentioned this pull request Aug 28, 2023

Fix the setupNode action failing on npx patch-package #25988

Merged

59 tasks

mountiny added the Ready To Build label Aug 28, 2023

tjferriss mentioned this pull request Aug 30, 2023

[HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$1000] CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything #25527

Closed

6 tasks

mountiny assigned shubham1206agra Aug 31, 2023

mountiny mentioned this pull request Aug 31, 2023

Simplify Global Create menu #25564

Merged

58 tasks

Merge branch 'Expensify:main' into revert-25963-revert-25866-react-na…

2f01500

…vigation-native-fix

shubham1206agra marked this pull request as ready for review August 31, 2023 16:09

shubham1206agra requested a review from a team as a code owner August 31, 2023 16:09

melvin-bot bot requested review from Ollyws and removed request for a team August 31, 2023 16:10

mountiny self-requested a review August 31, 2023 20:18

shubham1206agra mentioned this pull request Sep 1, 2023

[HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit #25626

Closed

6 tasks

Merge branch 'Expensify:main' into revert-25963-revert-25866-react-na…

a208c50

…vigation-native-fix

mountiny changed the title ~~Fixing the race condition on history.go due to buggy queue async callbacks~~ [CP Staging] Fixing the race condition on history.go due to buggy queue async callbacks Sep 1, 2023

mountiny approved these changes Sep 1, 2023

View reviewed changes

mountiny merged commit 12a6f87 into Expensify:main Sep 1, 2023

mountiny mentioned this pull request Sep 1, 2023

Deploy Checklist: New Expensify 2023-08-31 #26444

Closed

36 tasks

fabOnReact mentioned this pull request Sep 11, 2023

[HOLD for payment 2023-09-29] [$1000] Android - Login - Linkified email from external app is pasted as linkified email in email field #21411

Closed

6 tasks

shubham1206agra deleted the revert-25963-revert-25866-react-navigation-native-fix branch September 22, 2023 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fixing the race condition on `history.go` due to buggy queue async callbacks #25989

[CP Staging] Fixing the race condition on `history.go` due to buggy queue async callbacks #25989

shubham1206agra commented Aug 26, 2023 •

edited by mountiny

Loading

shubham1206agra commented Aug 26, 2023

melvin-bot bot commented Aug 31, 2023

shubham1206agra commented Aug 31, 2023

shubham1206agra commented Sep 1, 2023

mountiny commented Sep 1, 2023 •

edited

Loading

mountiny left a comment

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

[CP Staging] Fixing the race condition on history.go due to buggy queue async callbacks #25989

[CP Staging] Fixing the race condition on history.go due to buggy queue async callbacks #25989

Conversation

shubham1206agra commented Aug 26, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests / QA Steps

Additional Test

PR Author Checklist

Screenshots/Videos

shubham1206agra commented Aug 26, 2023

melvin-bot bot commented Aug 31, 2023

shubham1206agra commented Aug 31, 2023

shubham1206agra commented Sep 1, 2023

mountiny commented Sep 1, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

[CP Staging] Fixing the race condition on `history.go` due to buggy queue async callbacks #25989

[CP Staging] Fixing the race condition on `history.go` due to buggy queue async callbacks #25989

shubham1206agra commented Aug 26, 2023 •

edited by mountiny

Loading

mountiny commented Sep 1, 2023 •

edited

Loading