Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show recent waypoints when selecting address for distance request #25974

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Show recent waypoints when selecting address for distance request #25974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c4f93a3
Add the onyx key
tgolen Aug 25, 2023
c50feeb
Display recent searches
tgolen Aug 25, 2023
f9dcecf
Cleanup the data passed to autocomplete
tgolen Aug 25, 2023
f58407a
Fix prop references
tgolen Aug 25, 2023
2c9ffa5
Store recent waypoints optimistically
tgolen Aug 25, 2023
e791e02
Import underscore
tgolen Aug 28, 2023
b818dba
Revert onPress handler logic
tgolen Aug 28, 2023
ff8e227
Clone waypoints and remove paranoid logic
tgolen Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libs/actions/Transaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ function saveWaypoint(transactionID, index, waypoint) {
});
const recentWaypointAlreadyExists = _.find(recentWaypoints, (recentWaypoint) => recentWaypoint.address === waypoint.address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this caused a deploy blocker

if (!recentWaypointAlreadyExists) {
recentWaypoints.unshift(waypoint);
Onyx.merge(ONYXKEYS.NVP_RECENT_WAYPOINTS, recentWaypoints.slice(0, 5));
const clonedWaypoints = _.clone(recentWaypoints);
clonedWaypoints.unshift(waypoint);
Onyx.merge(ONYXKEYS.NVP_RECENT_WAYPOINTS, clonedWaypoints.slice(0, 5));
Comment on lines +98 to +100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of doing slice 0, 4 first and add the other item. but not a blocker

}
}

Expand Down
2 changes: 1 addition & 1 deletion src/pages/iou/WaypointEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export default compose(
// Only grab the most recent 5 waypoints because that's all that is shown in the UI. This also puts them into the format of data
// that the google autocomplete component expects for it's "predefined places" feature.
selector: (waypoints) =>
_.map(waypoints && waypoints.length ? waypoints.slice(0, 5) : [], (waypoint) => ({
_.map(waypoints ? waypoints.slice(0, 5) : [], (waypoint) => ({
description: waypoint.address,
geometry: {
location: {
Expand Down