Fix/24314 the search field does not focus when selecting money request participants #25922

Swor71 · 2023-08-25T10:25:37Z

Details

This PR fixes the issue of the search field not being focused when selecting money request participants. By adding shouldDelayFocus prop to OptionsSelector in MoneyRequestParticipantsSelector the focus is delayed to give time for transitions to play out (as it's stated in the BaseOptionsSelector component).

This works on Chrome on Android, Safari on iOS and regular Chrome web browser as you can see in the provided videos below.

Fixed Issues

$ #24314
PROPOSAL: as per these comments and an actual one line change we opted for omitting the proposal stage

Tests

Open the browser (Chrome on Android, Safari on iOS, Chrome on Desktop)
Navigate to the new dot on DEV environment and log in to an account
Press on FAB and select request money from the pop up
Fill in the amount and press Next button
Confirm that after navigating to the next screen where you would select a user, the input is focused and the keyboard is open (on mobile web)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the browser (Chrome on Android, Safari on iOS, Chrome on Desktop)
Navigate to the new dot on DEV environment and log in to an account
Press on FAB and select request money from the pop up
Fill in the amount and press Next button
Confirm that after navigating to the next screen where you would select a user, the input is focused and the keyboard is open (on mobile web)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-25.at.12.02.09.mov

Mobile Web - Chrome

Screen.Recording.2023-08-24.at.16.33.25.mov

Mobile Web - Safari

Screen.Recording.2023-08-25.at.11.53.24.mov

Desktop

iOS

Android

melvin-bot · 2023-08-25T11:04:18Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-08-25T13:43:11Z

@Swor71 Please complete the checklist

Swor71 · 2023-08-25T15:12:04Z

@cubuspl42 hey, updated the checklist

Swor71 · 2023-08-31T09:03:21Z

@cubuspl42 hey, would you have a moment to give this one a review, please?

cubuspl42 · 2023-08-31T09:05:45Z

@Swor71 I'm very sorry, I missed that notification. Catching up.

cubuspl42 · 2023-08-31T09:08:29Z

@Swor71 Please merge main

cubuspl42 · 2023-08-31T09:14:43Z

@Swor71 Is this summary valid?

Swor71 · 2023-08-31T09:21:37Z

@cubuspl42 oh, just noticed someone changed this as in the beginning it was only a browser issue and I didn't see this happening while checking native. I'd focus on Chrome on Android, Safari on iOS and Chrome for desktop tbh

cubuspl42 · 2023-08-31T09:23:27Z

I'm just establishing facts. It's quite important to know what wasn't working to determine whether it was fixed!

cubuspl42 · 2023-08-31T09:56:19Z

@Swor71 I'm not able to reproduce the issue on any platform on main. I tried physical iOS, too. On which platforms/devices were you able to reproduce it?

Swor71 · 2023-08-31T10:11:43Z

@cubuspl42 I'll double check myself in a moment with the latest main, but I last week I could reproduce it on iPhone 14 Pro iOS 16.4 and Pixel 5 API 31 as well as just regular web build tested in Chrome

Swor71 · 2023-08-31T10:59:43Z

@cubuspl42 I can still reproduce the issue with the latest main. The input is not focused after pressing next on request money screen. Just to make sure we're on the same page - this happens in the browser, not the native apps

cubuspl42 · 2023-09-01T07:57:38Z

@Swor71

request-money-focus-compressed.mp4

I's a bit tricky case. I'm aware that other people also had trouble reproducing it:

[$1000] DEV: The search field does not focus when selecting money request participants #24314 (comment)
[$1000] DEV: The search field does not focus when selecting money request participants #24314 (comment)

In general, I should confirm that your PR fixed the issue, but the best I can do is to confirm that what was working (for me!) is still working.

What I suggest is that you additionally include the recordings from all platforms where you are able to reproduce the bug on main in the "Screenshots/Videos" section. We'll later see what the internal engineer has to say about this case.

cubuspl42 · 2023-09-01T09:06:50Z

@Swor71 The plot thickens. I'm now able to reproduce the issue on the PR branch... (iOS Simulator / Safari)

request-money-focus-ios-web-repro1.mov

Swor71 · 2023-09-04T12:32:45Z

@cubuspl42 Latest main, still able to reproduce the issue on Chrome, Chrome Android, Safari iOS

Screen.Recording.2023-09-04.at.14.24.26.mov

Screen.Recording.2023-09-04.at.14.26.36.mov

Screen.Recording.2023-09-04.at.14.27.49.mov

cubuspl42 · 2023-09-04T15:59:09Z

@Swor71 I wasn't joking, I now am able to reproduce the problem on iOS/Safari, on your branch, after the supposed fix. Both simulator and physical. So we have a problem.

gadhiyamanan · 2023-09-05T07:41:11Z

@cubuspl42 we have already open issue for iOS/Safari

[$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414

cubuspl42 · 2023-09-05T08:03:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

request-money-focus-web.mp4

Mobile Web - Chrome

request-money-focus-android-web-compressed.mp4

Mobile Web - Safari

request-money-focus-ios-web.mp4

Desktop

iOS

request-money-focus-ios.mp4

Android

request-money-focus-android-compressed.mp4

cubuspl42 · 2023-09-05T08:04:30Z

@gadhiyamanan

@cubuspl42 we have already open issue for iOS/Safari

* [[$8000] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414](https://github.com/Expensify/App/issues/10414)

Thank you!

cubuspl42 · 2023-09-05T08:06:34Z

@Swor71 I was finally able to properly reproduce the bug on main. On iOS/Safari, the keyboard doesn't open for me, but it indeed looks like #10414. It's interesting that it doesn't affect you, though.

Swor71 · 2023-09-05T10:38:54Z

@Swor71 I was finally able to properly reproduce the bug on main. On iOS/Safari, the keyboard doesn't open for me, but it indeed looks like #10414. It's interesting that it doesn't affect you, though.

@cubuspl42 that's indeed interesting, I've had the same experience being able to reproduce the issue on consecutive attempts (always with latest main) and then having it fixed by adding the delay prop, and on all mentioned platforms.

cubuspl42 · 2023-09-05T11:15:54Z

@Swor71 To be honest, I think I might've done a silly mistake during switching branches. I think that would explain it.

But I'm still not sure why you don't reproduce #10414

luacmartins

LGTM but we're on a merge freeze for our conferences this week. Gonna have to come bacak to merge this later.

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

luacmartins

@Swor71 let's change the solution to use onTransitionEnd please

Swor71 · 2023-09-13T09:12:21Z

@luacmartins hey, I understand that you mean onEntryTransitionEnd from ScreenWrapper? I wasn't aware of this approach, and the decision to standardise to it, but I'll have a go at it 👍🏻

luacmartins · 2023-09-13T09:24:17Z

Yes, thank you for the understanding!

Swor71 · 2023-09-13T12:31:23Z

@luacmartins @cubuspl42
just pushed the changes, please have another look if this is what you had in mind, thanks!

One thing I noticed, but it might be this particular emulator as it was not so visible before or at all with shouldDelayFocus, is the Android keyboard briefly closing and popping up again. I'll check a different device as well.

Platform vids with those changes:

Screen.Recording.2023-09-13.at.14.07.31.mov

Screen.Recording.2023-09-13.at.14.08.04.mov

Screen.Recording.2023-09-13.at.14.19.51.mov

src/components/OptionsSelector/BaseOptionsSelector.js

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

luacmartins · 2023-09-14T00:20:03Z

@Swor71 we also have conflicts

Swor71 · 2023-09-14T09:53:35Z

@luacmartins @cubuspl42
I noticed the conflict today and wanted to solve it but it turns out this PR was merged yesterday basically introducing the same changes. How would you like to proceed?

luacmartins · 2023-09-15T00:34:05Z

It seems like we already fixed the issue then. Maybe we should just close this PR.

cubuspl42 · 2023-09-15T10:09:33Z

@luacmartins You said "maybe", so what are the other options? 😃

I say we close it, and let's move the discussion to our original issue.

luacmartins · 2023-09-18T00:47:04Z

Yea, let's close this.

add shouldDelayFocus prop to OptionsSelector

a308f76

Swor71 changed the title ~~add shouldDelayFocus prop to OptionsSelector~~ Fix/24314 the search field does not focus when selecting money request participants Aug 25, 2023

Swor71 marked this pull request as ready for review August 25, 2023 11:04

Swor71 requested a review from a team as a code owner August 25, 2023 11:04

melvin-bot bot removed the request for review from a team August 25, 2023 11:04

melvin-bot bot requested a review from cubuspl42 August 25, 2023 11:04

Swor71 mentioned this pull request Aug 25, 2023

[$1000] DEV: The search field does not focus when selecting money request participants #24314

Closed

6 tasks

GItGudRatio mentioned this pull request Aug 29, 2023

Changing currency closes the request Modal #26260

Closed

6 tasks

Merge branch 'main' into fix/24314-search-field-does-not-focus

6e8e944

cubuspl42 approved these changes Sep 5, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins September 5, 2023 08:07

Merge branch 'main' into fix/24314-search-field-does-not-focus

19a474d

luacmartins approved these changes Sep 5, 2023

View reviewed changes

situchan mentioned this pull request Sep 6, 2023

[$500] Dev: Web - Input fields are not auto focused on "Cash" page #26380

Closed

6 tasks

rushatgabhane reviewed Sep 6, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js Outdated Show resolved Hide resolved

luacmartins requested changes Sep 13, 2023

View reviewed changes

Swor71 added 2 commits September 13, 2023 12:33

Merge branch 'main' into fix/24314-search-field-does-not-focus

5a948ab

change shouldDelayFocus prop to use onEntryTransitionEnd and ref

2a0d841

luacmartins requested changes Sep 14, 2023

View reviewed changes

src/components/OptionsSelector/BaseOptionsSelector.js Show resolved Hide resolved

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Show resolved Hide resolved

luacmartins closed this Sep 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/24314 the search field does not focus when selecting money request participants #25922

Fix/24314 the search field does not focus when selecting money request participants #25922

Swor71 commented Aug 25, 2023 •

edited

Loading

melvin-bot bot commented Aug 25, 2023

cubuspl42 commented Aug 25, 2023

Swor71 commented Aug 25, 2023 •

edited

Loading

Swor71 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

Swor71 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

Swor71 commented Aug 31, 2023

Swor71 commented Aug 31, 2023 •

edited

Loading

cubuspl42 commented Sep 1, 2023

cubuspl42 commented Sep 1, 2023

Swor71 commented Sep 4, 2023

cubuspl42 commented Sep 4, 2023

gadhiyamanan commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

Swor71 commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

luacmartins left a comment

luacmartins left a comment

Swor71 commented Sep 13, 2023

luacmartins commented Sep 13, 2023

Swor71 commented Sep 13, 2023

luacmartins commented Sep 14, 2023

Swor71 commented Sep 14, 2023

luacmartins commented Sep 15, 2023

cubuspl42 commented Sep 15, 2023 •

edited

Loading

luacmartins commented Sep 18, 2023

Fix/24314 the search field does not focus when selecting money request participants #25922

Fix/24314 the search field does not focus when selecting money request participants #25922

Conversation

Swor71 commented Aug 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 25, 2023

cubuspl42 commented Aug 25, 2023

Swor71 commented Aug 25, 2023 • edited Loading

Swor71 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

Swor71 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

Swor71 commented Aug 31, 2023

Swor71 commented Aug 31, 2023 • edited Loading

cubuspl42 commented Sep 1, 2023

cubuspl42 commented Sep 1, 2023

Swor71 commented Sep 4, 2023

cubuspl42 commented Sep 4, 2023

gadhiyamanan commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

Reviewer Checklist

Screenshots/Videos

cubuspl42 commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

Swor71 commented Sep 5, 2023

cubuspl42 commented Sep 5, 2023

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

Swor71 commented Sep 13, 2023

luacmartins commented Sep 13, 2023

Swor71 commented Sep 13, 2023

luacmartins commented Sep 14, 2023

Swor71 commented Sep 14, 2023

luacmartins commented Sep 15, 2023

cubuspl42 commented Sep 15, 2023 • edited Loading

luacmartins commented Sep 18, 2023

Swor71 commented Aug 25, 2023 •

edited

Loading

Swor71 commented Aug 25, 2023 •

edited

Loading

Swor71 commented Aug 31, 2023 •

edited

Loading

cubuspl42 commented Sep 15, 2023 •

edited

Loading