[NO QA] [HOLD] Add instruction on setting up Mapbox credentials #25454
Conversation
hayata-suenaga
changed the title
melvin-bot
bot
requested review from
abdulrahuman5196
and removed request for
a team
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@hayata-suenaga I have been assigned the auto C+ here? What should we do as C+ here? |
|
Also merge conflicts |
|
You've got more conflicts, I'm afraid. |
hayata-suenaga
changed the title
|
I have to change the instruction in README because of this issue. I added HOLD so that this PR cannot be merged. |
|
@hayata-suenaga Is this PR still needed? |
|
yes this PR is still needed but we're holding this issue until the end of this month as this touches a build system (and there are new features merged evertyday until a big conference at the end of this month |
|
Thank you for confirming. I was just checking through my K2 for pending items. |
|
Closing the PR as we're not deploying Mapbox script PR |
Details
We added a new library that uses native iOS and Android Mapbox SDKs. Mapbox is the service that offers, well, maps along with other map-related services. One caveat of using their SDKs is that they're closed-sourced, and you need a token to download them.
We created scripts
setup-mapbox-sdksandsetup-mapbox-sdks-walkthroughfor streamline the process of obtaining the token and saving the token in the local environment. These scripts are invoked when runningnpm run configure-mapbox.However, this script might not work for everyone, especially those developing on Windows computers. This PR adds instructions on manually obtaining and saving tokens.
Fixed Issues
$ #25452
PROPOSAL: N/A
Test
This is a change in a documentation. No test or QA is needed.
cc: @neil-marcellini