-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display single waypoint #25161
Merged
Merged
Display single waypoint #25161
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fe987ff
temp
b98ee9a
feat: display way points
da60206
chore: use SF coordinate for placeholder data
62e5815
style: run prettier
5e19550
fix: filter out undefined waypoints
342f344
chore(deps): install new version of x-maps
dd7f3f4
chore: use the code from test branch for the map lib
b31cea8
chore: update pod version
bd84bb8
fix: pass width prop so that marker is displayed on ios
9387d15
chore: change test branch
1817dbf
Merge branch 'main' into hayata-test-route-style
c7e472c
chore(dep): bump package version
bc099f1
chore(dep): run npm install
5518086
style: rename a variable
40eecdb
fix: check for null
a9b1cde
fix: change icon color
9fa23b0
feat: use Expensify style in map
0c08d09
chore(deps): update x-maps version
b2416eb
fix: hide link url
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding waypoints, we should have changed the default location from SF to the first value in waypoints to keep animations consist (coming from #29471)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that's a good point. Thank for letting us know!