setting required field errors in app #24379

chiragxarora · 2023-08-10T16:36:19Z

Details

wrong error messages on various pages for different cases, no field required error present

Fixed Issues

$ #23954
PROPOSAL: #23954 (comment)

Tests

open the app and visit the following pages:
1.1. settings > workspace > bank accounts > manual
1.2. settings > workspace > bank accounts > manual > company info
1.3. settings > workspace > bank accounts > manual > company info > personal info
1.4. settings > payments > debitcard
1.5. settings > security > close account
1.6. settings > profile > personal details > date of birth
1.7. settings > payments > paypal
1.8 localhost:PORT/enable-payments
submit all the forms without filling any value
observe that field required error pops on the fields
now enter some invalid values for those fields and verify the error message changes to a validation error, if applicable.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

open the app and visit the following pages:
1.1. settings > workspace > bank accounts > manual
1.2. settings > workspace > bank accounts > manual > company info
1.3. settings > workspace > bank accounts > manual > company info > personal info
1.4. settings > payments > debitcard
1.5. settings > security > close account
1.6. settings > profile > personal details > date of birth
1.7. settings > payments > paypal
submit all the forms without filling any value
observe that field required error pops on the fields
now enter some invalid values for those fields and verify the error message changes to a validation error, if applicable.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-17.at.2.35.42.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-17.at.11.53.20.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-17.at.11.35.54.PM.mov

Desktop

Screen.Recording.2023-08-17.at.2.39.08.AM.mov

iOS

Screen.Recording.2023-08-17.at.11.32.32.PM.mov

Android

261604005-045d5abe-96b7-4468-94ea-30c8450d9d7e.1.mp4

chiragxarora · 2023-08-15T10:21:42Z

Notes for PR:

error message for state picker? (debit card page)
error message for state picker? (company step page)
close account page??

melvin-bot · 2023-08-16T10:49:44Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chiragxarora · 2023-08-16T10:58:03Z

few questions for you @Ollyws

What error to show for empty state field?

This field is required or please select a state

currently the later one is used and I think that makes sense, or do I need to handle it together with the req. fields to show the former message?

And what about the close account page, do we need required field error there?

Ollyws · 2023-08-16T14:50:53Z

@chiragxarora I think please select a state is fine, as it's a selection-list. Thinking about close account page, it does seem congruent to add it there too. Thanks.

src/pages/EnablePayments/AdditionalDetailsStep.js

chiragxarora · 2023-08-17T11:51:00Z

Bumping for review: @Ollyws

Ollyws · 2023-08-17T16:03:07Z

@chiragxarora After testing it I think that having the state field as the only one without This field is required does look a little incongruent. Can we add it here too please, thanks.

chiragxarora · 2023-08-17T16:09:34Z

on it

chiragxarora · 2023-08-17T16:18:02Z

done @Ollyws

chiragxarora · 2023-08-17T16:18:14Z

pls review again

Ollyws · 2023-08-17T16:40:02Z

@chiragxarora Also AddressState in CompanyStep please, thanks!

chiragxarora · 2023-08-17T16:41:21Z

@chiragxarora Also AddressState in CompanyStep please, thanks!

done @Ollyws , sorry about that

Ollyws · 2023-08-17T16:55:41Z

@chiragxarora Thanks, also one more in PersonalInformation

chiragxarora · 2023-08-17T16:56:42Z

In which folder?

Ollyws · 2023-08-17T16:58:51Z

@chiragxarora RequestorStep

chiragxarora · 2023-08-17T17:01:46Z

done @Ollyws

Ollyws · 2023-08-17T17:08:41Z

@chiragxarora Thanks, you might also need to do npm run prettier to get the lint check passing.

chiragxarora · 2023-08-17T17:10:58Z

done @Ollyws

chiragxarora · 2023-08-18T10:01:39Z

bumping for review @Ollyws

Ollyws · 2023-08-18T12:27:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

MacOS_Chrome.mp4

Mobile Web - Chrome

Android_Chrome.mp4

Mobile Web - Safari

iOS_Safari.mp4

Desktop

MacOS_Desktop.mp4

iOS

iOS_Native.mp4

Android

Android_Native.mp4

Ollyws · 2023-08-18T12:54:47Z

@chiragxarora Thanks for your patience.
Could we change step 4 in the testing steps to read:
now enter some invalid values for those fields and verify the error message changes to a validation error, if applicable.

chiragxarora · 2023-08-18T13:04:46Z

@chiragxarora Thanks for your patience.
Could we change step 4 in the testing steps to read:
now enter some invalid values for those fields and verify the error message changes to a validation error, if applicable.

Doneee

chiragxarora · 2023-08-18T13:55:36Z

I see everything ticked in the checklist, is it ready to be approved now @Ollyws ?

Or we are waiting for something?

Ollyws · 2023-08-18T13:59:55Z

Just having a final run through.

chiragxarora · 2023-08-18T14:26:27Z

Okay cool!

Ollyws

LGTM

OSBotify · 2023-08-18T17:47:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:24:19Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:07:20Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

chiragxarora added 13 commits August 10, 2023 21:41

getFieldRequiredErrors util created

0f775f6

jsdoc edit

dae2c4b

debitcardpage fixed

fe6bd37

paypalme page fixed

672203c

dob page fixed

f62658f

merge main

1a755f8

bankaccountmanualstep page fixed

7fe0802

variable rename

8e0bb21

companystep page fixed

f686c7f

requestor page fixed

9e70f42

prettier

12bd6a7

merge main

450f1bb

additionaldetailsstep page fixed

d9688aa

chiragxarora marked this pull request as ready for review August 16, 2023 10:49

chiragxarora requested a review from a team as a code owner August 16, 2023 10:49

melvin-bot bot requested review from Ollyws and removed request for a team August 16, 2023 10:49

merge main

627f365

Ollyws reviewed Aug 16, 2023

View reviewed changes

src/pages/EnablePayments/AdditionalDetailsStep.js Show resolved Hide resolved

chiragxarora added 2 commits August 16, 2023 21:31

close account page fixed

78850e2

date errors fixed

97ea069

state added to req fields

7038aff

fix

3f9a9d7

remaining state error

97b6e53

prettier

97a3e6c

merge main

aaf4813

Ollyws approved these changes Aug 18, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa August 18, 2023 14:38

bondydaa assigned chiragxarora Aug 18, 2023

bondydaa approved these changes Aug 18, 2023

View reviewed changes

bondydaa merged commit 0c35910 into Expensify:main Aug 18, 2023

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

lanitochka17 mentioned this pull request Aug 24, 2023

Add Bank Account - Generic error when entering numbers instead of letters in first/last name #25836

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

setting required field errors in app #24379

setting required field errors in app #24379

chiragxarora commented Aug 10, 2023 •

edited

Loading

chiragxarora commented Aug 15, 2023

melvin-bot bot commented Aug 16, 2023

chiragxarora commented Aug 16, 2023

Ollyws commented Aug 16, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

chiragxarora commented Aug 18, 2023

Ollyws commented Aug 18, 2023

Ollyws commented Aug 18, 2023

chiragxarora commented Aug 18, 2023

chiragxarora commented Aug 18, 2023 •

edited

Loading

Ollyws commented Aug 18, 2023

chiragxarora commented Aug 18, 2023

Ollyws left a comment

OSBotify commented Aug 18, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

setting required field errors in app #24379

setting required field errors in app #24379

Conversation

chiragxarora commented Aug 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

chiragxarora commented Aug 15, 2023

melvin-bot bot commented Aug 16, 2023

chiragxarora commented Aug 16, 2023

Ollyws commented Aug 16, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

Ollyws commented Aug 17, 2023

chiragxarora commented Aug 17, 2023

chiragxarora commented Aug 18, 2023

Ollyws commented Aug 18, 2023

Reviewer Checklist

Screenshots/Videos

Ollyws commented Aug 18, 2023

chiragxarora commented Aug 18, 2023

chiragxarora commented Aug 18, 2023 • edited Loading

Ollyws commented Aug 18, 2023

chiragxarora commented Aug 18, 2023

Ollyws left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 18, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

chiragxarora commented Aug 10, 2023 •

edited

Loading

chiragxarora commented Aug 18, 2023 •

edited

Loading