Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Onyx type core data #24054

Merged
merged 130 commits into from
Aug 22, 2023
Merged

[No QA] Onyx type core data #24054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
130 commits
Select commit Hold shift + click to select a range
0989715
Initial work on onyx types
blazejkustra Jun 29, 2023
13ee74d
Change comments to JSDOC
blazejkustra Jun 29, 2023
c8ed8f9
Improve onyx common types + finish account type
blazejkustra Jun 29, 2023
b8fdc46
Add type for ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID
blazejkustra Jun 29, 2023
2e2f1e0
Add type for ONYXKEYS.NVP_IS_FIRST_TIME_NEW_EXPENSIFY_USER
blazejkustra Jun 29, 2023
fe9faf1
Add type for ONYXKEYS.ACTIVE_CLIENTS
blazejkustra Jun 29, 2023
6d8223d
Add type for ONYXKEYS.DEVICE_ID
blazejkustra Jun 29, 2023
418fd37
Add type for ONYXKEYS.IS_SIDEBAR_LOADED
blazejkustra Jun 29, 2023
46a9fd0
Add type for ONYXKEYS.QUEUED_ONYX_UPDATES
blazejkustra Jun 29, 2023
e66f1f9
Add type for ONYXKEYS.CURRENT_DATE
blazejkustra Jun 29, 2023
82671a0
Change the structure a bit
blazejkustra Jun 30, 2023
c78cd76
Add type for ONYXKEYS.CREDENTIALS
blazejkustra Jun 30, 2023
47181cd
Add type for ONYXKEYS.IOU
blazejkustra Jun 30, 2023
87d7c87
Add type for ONYXKEYS.MODAL
blazejkustra Jun 30, 2023
08c951a
Add type for ONYXKEYS.NETWORK
blazejkustra Jul 4, 2023
2c117f9
Add type for ONYXKEYS.PERSONAL_DETAILS_LIST
blazejkustra Jul 4, 2023
8f28192
Add type for ONYXKEYS.PRIVATE_PERSONAL_DETAILS
blazejkustra Jul 4, 2023
83d87c6
Add type for ONYXKEYS.TASK
blazejkustra Jul 4, 2023
d9dbcec
Add type for ONYXKEYS.CURRENCY_LIST
blazejkustra Jul 4, 2023
dbb9b63
Add type for ONYXKEYS.UPDATE_AVAILABLE
blazejkustra Jul 4, 2023
9d33b9d
Add type for ONYXKEYS.SCREEN_SHARE_REQUEST
blazejkustra Jul 4, 2023
1e0f66b
Add type for ONYXKEYS.COUNTRY_CODE
blazejkustra Jul 4, 2023
c9c0425
Add type for ONYXKEYS.USER
blazejkustra Jul 4, 2023
f9976ed
Add type for ONYXKEYS.LOGIN
blazejkustra Jul 4, 2023
6990be1
Add type for ONYXKEYS.SESSION
blazejkustra Jul 4, 2023
40e7bdc
Add type for ONYXKEYS.BETAS
blazejkustra Jul 4, 2023
c98189a
Add type for ONYXKEYS.PAYPAL
blazejkustra Jul 5, 2023
85bfc4e
Add type for ONYXKEYS.NVP_PRIORITY_MODE
blazejkustra Jul 5, 2023
548fd4a
Add type for ONYXKEYS.NVP_BLOCKED_FROM_CONCIERGE
blazejkustra Jul 5, 2023
53b466f
Add type for ONYXKEYS.NVP_PRIVATE_PUSH_NOTIFICATION_ID
blazejkustra Jul 5, 2023
a748462
Add type for ONYXKEYS.NVP_LAST_PAYMENT_METHOD
blazejkustra Jul 5, 2023
3c73f40
Add type for ONYXKEYS.PUSH_NOTIFICATIONS_ENABLED
blazejkustra Jul 5, 2023
d53b28d
Add type for ONYXKEYS.PLAID_DATA
blazejkustra Jul 5, 2023
68350a0
Add all values and type booleans
blazejkustra Jul 5, 2023
c17349a
Add type for ONYXKEYS.PLAID_LINK_TOKEN
blazejkustra Jul 5, 2023
358bd6e
Add type for ONYXKEYS.ONFIDO_TOKEN
blazejkustra Jul 5, 2023
4e0728a
Add type for ONYXKEYS.NVP_PREFERRED_LOCALE
blazejkustra Jul 5, 2023
8d0712c
Remove TRANSACTIONS_BEING_REJECTED as it is not used
blazejkustra Jul 5, 2023
439e2e3
Add type for ONYXKEYS.USER_WALLET
blazejkustra Jul 5, 2023
3631ceb
Add type for ONYXKEYS.WALLET_ONFIDO
blazejkustra Jul 5, 2023
77840a3
Add type for ONYXKEYS.WALLET_ADDITIONAL_DETAILS
blazejkustra Jul 5, 2023
49a0be1
Add type for ONYXKEYS.WALLET_TERMS
blazejkustra Jul 5, 2023
96ddb62
Add type for ONYXKEYS.BANK_ACCOUNT_LIST
blazejkustra Jul 5, 2023
7ad0a1c
Add type for ONYXKEYS.CARD_LIST
blazejkustra Jul 5, 2023
8beae08
Add type for ONYXKEYS.WALLET_STATEMENT
blazejkustra Jul 5, 2023
2efd61d
Add type for ONYXKEYS.PERSONAL_BANK_ACCOUNT
blazejkustra Jul 5, 2023
61adcc2
Add type for ONYXKEYS.LAST_OPENED_PUBLIC_ROOM_ID
blazejkustra Jul 5, 2023
fa5da57
Add type for ONYXKEYS.MY_DOMAIN_SECURITY_GROUPS
blazejkustra Jul 5, 2023
065b49a
Add type for ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT
blazejkustra Jul 5, 2023
d86d350
Add type for ONYXKEYS.LAST_ACCESSED_WORKSPACE_POLICY_ID
blazejkustra Jul 5, 2023
e7be147
Add type for ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE
blazejkustra Jul 5, 2023
084e6e3
Add type for ONYXKEYS.FREQUENTLY_USED_EMOJIS
blazejkustra Jul 5, 2023
77a0047
Add type for ONYXKEYS.REIMBURSEMENT_ACCOUNT & REIMBURSEMENT_ACCOUNT_D…
blazejkustra Jul 5, 2023
5d3877a
Add type for ONYXKEYS.WALLET_TRANSFER
blazejkustra Jul 5, 2023
e7b0ae5
Add type for FORMS
blazejkustra Jul 5, 2023
4f0ea3e
Add types for ONYXKEYS.COLLECTIONS
blazejkustra Jul 5, 2023
dec3f7a
Add types for ONYXKEYS.COLLECTION.DEPRECATED_POLICY_MEMBER_LIST
blazejkustra Jul 5, 2023
8b1dfb4
Move comment back to original place
blazejkustra Jul 5, 2023
56b79d0
Add types for ONYXKEYS.COLLECTION.POLICY
blazejkustra Jul 5, 2023
6291651
Add types for ONYXKEYS.COLLECTION.WORKSPACE_INVITE_MEMBERS_DRAFT
blazejkustra Jul 5, 2023
c875d5a
Add types for ONYXKEYS.COLLECTION.REPORT
blazejkustra Jul 5, 2023
0a522fa
Add types for ONYXKEYS.COLLECTION.REPORT_ACTIONS
blazejkustra Jul 5, 2023
f21bb70
Add types for ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS
blazejkustra Jul 5, 2023
3dbccd9
Remove COLLECTION.REPORT_ACTIONS_REACTIONS as it is not used
blazejkustra Jul 5, 2023
422a1fc
Add types for ONYXKEYS.COLLECTION.REPORT related collections
blazejkustra Jul 5, 2023
854a8f9
Add types for ONYXKEYS.COLLECTION.SECURITY_GROUP
blazejkustra Jul 5, 2023
9276a22
Add types for ONYXKEYS.COLLECTION.TRANSACTION
blazejkustra Jul 5, 2023
0b4146a
Changes after initial review
blazejkustra Jul 6, 2023
c3a7a87
Type errors better
blazejkustra Jul 7, 2023
00ec1a4
Add missing types from ReportAction
blazejkustra Jul 7, 2023
243377b
Replace REIMBURSEMENT_ACCOUNT_FORM with REIMBURSEMENT_ACCOUNT
blazejkustra Jul 7, 2023
f91267d
Add missing Report types
blazejkustra Jul 7, 2023
ac27dd3
Rename FieldErrors to ErrorFields
blazejkustra Jul 7, 2023
d218629
Correct types after review
blazejkustra Jul 7, 2023
842985e
Type persisted requests
blazejkustra Jul 7, 2023
6321e34
Fix namings and comments
blazejkustra Jul 10, 2023
b564671
Add changes to UserWallet
blazejkustra Jul 12, 2023
96b72c9
Fix type utils structure
blazejkustra Jul 12, 2023
88b548d
Add more changes to UserWallet
blazejkustra Jul 12, 2023
178b697
Add accountId to Credentials
blazejkustra Jul 12, 2023
c258aaf
Update Account type
blazejkustra Jul 12, 2023
e2d2edb
Update ACHData type
blazejkustra Jul 12, 2023
4568e0e
Update Currency type
blazejkustra Jul 12, 2023
38b6280
Update User type
blazejkustra Jul 12, 2023
e511910
Add new onyx keys: PREFERRED_THEME and IS_USING_MEMORY_ONLY_KEYS
blazejkustra Jul 13, 2023
e97b29c
Change OnfidoWallet to WalletOnfido
blazejkustra Jul 13, 2023
3ad2a94
Adjust WalletOnfido
blazejkustra Jul 13, 2023
af9ec42
Adjust PersonalDetails
blazejkustra Jul 13, 2023
9854cdf
Adjust IOU
blazejkustra Jul 13, 2023
ce377f9
Adjust BlockedFromConcierge
blazejkustra Jul 17, 2023
3197d7b
Adjust FrequentlyUsedEmoji
blazejkustra Jul 17, 2023
bd127d3
Adjust Paypal
blazejkustra Jul 17, 2023
436e009
Fix a typo
blazejkustra Jul 17, 2023
6da3ffb
Adjust BankAccount
blazejkustra Jul 18, 2023
c5e745e
Adjust ReportAction
blazejkustra Jul 18, 2023
43e2812
Adjust Transaction
blazejkustra Jul 18, 2023
9e17430
Adjust Card
blazejkustra Jul 18, 2023
f81d067
Adjust BlockedFromConcierge
blazejkustra Jul 18, 2023
aba2593
Adjust Transaction
blazejkustra Jul 18, 2023
0824e2c
Adjust ReimbursementAccountDraft
blazejkustra Jul 18, 2023
7fb38e8
Adjust ReimbursementAccount
blazejkustra Jul 18, 2023
70d2443
Adjust PrivatePersonalDetails
blazejkustra Jul 18, 2023
2e32657
Adjust Policy
blazejkustra Jul 19, 2023
2f736a1
Adjust types after feedback
blazejkustra Jul 19, 2023
0c9e3bc
Extract original message to a separate file
blazejkustra Jul 20, 2023
0f8b1dd
Add remaining original messages types
blazejkustra Jul 20, 2023
ae25eb4
Make fields optional
blazejkustra Jul 21, 2023
539f775
Adjust ReimbursementAccountDraft
blazejkustra Jul 24, 2023
e25861f
Remove BaseState completely
blazejkustra Jul 24, 2023
ba79ba6
Last adjustmnets to types
blazejkustra Jul 25, 2023
68e8255
Fix a typo
blazejkustra Jul 27, 2023
de467c9
Merge branch 'blazejkustra/typescript-poc' into typescript/onyx-types
blazejkustra Aug 1, 2023
2e14ef0
Fix eslint errors
blazejkustra Aug 1, 2023
e8b27af
Adjust the PR after last review
blazejkustra Aug 1, 2023
bcd4a90
Add types for ONYXKEYS.COLLECTION.REPORT_ACTIONS_REACTIONS
blazejkustra Aug 2, 2023
c7fb74a
Overwrite react-native-onyx in global.d.ts
blazejkustra Aug 3, 2023
1cee790
Change how onyx collection values are defined
blazejkustra Aug 3, 2023
62e479c
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 3, 2023
4eb4797
Remove flipper-plugin-bridgespy-client package
blazejkustra Aug 7, 2023
01bc2ec
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 7, 2023
6a2ddf1
Adjust types after review
blazejkustra Aug 8, 2023
4069588
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 8, 2023
77456a9
Add MAPBOX_ACCESS_TOKEN & ONYX_UPDATES
blazejkustra Aug 8, 2023
e070872
Install typed version of react-native-onyx
blazejkustra Aug 8, 2023
d733647
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 16, 2023
278183e
Fix CustomStatusDraft missing file
blazejkustra Aug 16, 2023
3eb82ca
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 17, 2023
23290ba
Reinstall deps
blazejkustra Aug 17, 2023
d58f198
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 21, 2023
e391b0f
Merge branch 'main' into typescript/onyx-types
blazejkustra Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 29 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@
"eslint-plugin-react-native-a11y": "^3.3.0",
"eslint-plugin-storybook": "^0.5.13",
"eslint-plugin-you-dont-need-lodash-underscore": "^6.12.0",
"flipper-plugin-bridgespy-client": "^0.1.9",
hayata-suenaga marked this conversation as resolved.
Show resolved Hide resolved
"html-webpack-plugin": "^5.5.0",
"jest": "29.4.1",
"jest-circus": "29.4.1",
Expand All @@ -257,7 +256,7 @@
"style-loader": "^2.0.0",
"time-analytics-webpack-plugin": "^0.1.17",
"type-fest": "^3.12.0",
"typescript": "^4.8.4",
"typescript": "^5.1.6",
hayata-suenaga marked this conversation as resolved.
Show resolved Hide resolved
"wait-port": "^0.2.9",
"webpack": "^5.76.0",
"webpack-bundle-analyzer": "^4.5.0",
Expand Down
Loading