[No QA] Improve instructions for migrating away from underscore #23668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
roryabraham
approved these changes
Jul 26, 2023
|
@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
We intentionally skipped the checklist for this documentation-only PR. Not an emergency |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
79 tasks
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.47-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
While reading this guide, I had some questions about the underscore migrating and Rory said that we are moving away from underscore and lodash and prefer vanilla code.
Fixed Issues
NA
Tests
NA
Offline tests
NA
QA Steps
NA
PR Author Checklist
NA - documentation only
Screenshots/Videos
NA - documentation only