Update ReportSettingsPage and NotificationPreferencePage permission #23255

ginsuma · 2023-07-20T10:56:48Z

Details

Update ReportSettingsPage and NotificationPreferencePage permission

Fixed Issues

$ #22997
PROPOSAL: #22997 (comment)

Tests

Open a DM report.
Copy report URL.
Add "/settings/"after the report URL and go to the new URL. Browser should show not found page.
Add "/settings/notification-preferences" after the report URL and go to the new URL. Browser should show not found page.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Safari

ios_safari.mov

Mobile Web - Chrome

android_chrome.mov

Desktop

desktop.mov

iOS

ios_app.mov

Android

android_app.mov

melvin-bot · 2023-07-20T10:56:53Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ginsuma · 2023-07-20T10:59:33Z

RoomNamePage permission is fixed by #22316.
ReportWelcomeMessagePage and WriteCapabilityPage is fixed by #22820.

robertKozik · 2023-07-20T12:11:13Z

Great 🚀 Will check it shortly!

robertKozik · 2023-07-20T12:11:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Desktop.-.web.mov

Mobile Web - Chrome

android.-.chrome.mov

Mobile Web - Safari

iOS.-.safari.mov

Desktop

desktop.-.native.mov

iOS

iOS.-.native.mov

Android

android.mov

robertKozik · 2023-07-20T14:14:31Z

@ginsuma I've encountered two new problems that I cannot reproduce on the latest main. Could you kindly check on your end whether your PR introduces them?

ginsuma · 2023-07-20T14:29:08Z

I did the check. Those problems happen when I register a new account. After reloading, I don't see it anymore. I don't think this PR caused it.
cc: @robertKozik

alexxxwork · 2023-07-20T19:25:45Z

@robertKozik also seen these errors on latest main and they are already in the main branch, not in this PR. I think they are in BaseSidebarScreen component

robertKozik · 2023-07-20T21:22:15Z

Thanks @ginsuma and @alexxxwork for checking and confirming.

robertKozik

One minor suggestion. Overall great job!

robertKozik · 2023-07-20T21:39:28Z

src/pages/settings/Report/ReportSettingsPage.js

@@ -80,7 +81,7 @@ class ReportSettingsPage extends Component {

        return (
            <ScreenWrapper>
-                <FullPageNotFoundView shouldShow={_.isEmpty(this.props.report)}>
+                <FullPageNotFoundView shouldShow={shouldDisableSettings}>


After the change FullPageNotFoundView was not checking whether this.props.report is empty. I'll add it for clear message (as I know it won't pass checks anyway) that we don't wont to show screen when no report is found.

Ok. Let me add it.

robertKozik

Great job 🚀

melvin-bot · 2023-07-21T15:08:23Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

arosiclair · 2023-07-21T15:09:14Z

Tests passed

OSBotify · 2023-07-21T15:12:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Pujan92 · 2023-07-21T15:21:31Z

@ginsuma @arosiclair Seems it is causing a regression where it is not showing correct room name in the Details page.

Screen.Recording.2023-07-21.at.8.50.36.PM.mov

ginsuma · 2023-07-21T15:37:17Z

@Pujan92 I removed isChatRoom in ReportDetailsPage in that PR.
Because my PR already merged so you can add it again in your PR to resolve conflict.

robertKozik · 2023-07-21T15:43:28Z

@ginsuma this problem is a regression from this PR, could you kindly open new PR with fix for that?

Pujan92 · 2023-07-21T15:43:29Z

I think that needs to fix in follow-up PR here, I am seeing this assignment seems wrong

App/src/pages/ReportDetailsPage.js

Line 64 in c225999

const shouldUseFullTitle = shouldDisableSettings;

robertKozik · 2023-07-21T15:45:43Z

@Pujan92 Yeah, it should be negated

ginsuma · 2023-07-21T16:09:34Z

@ginsuma this problem is a regression from this PR, could you kindly open new PR with fix for that?

@robertKozik #23358 please check here.
@Pujan92 Thank you a lot.

OSBotify · 2023-07-21T18:50:00Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:23:57Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:18Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

robertKozik · 2023-07-21T15:35:51Z

src/pages/ReportDetailsPage.js

@@ -155,7 +155,7 @@ function ReportDetailsPage(props) {
                                    tooltipEnabled
                                    numberOfLines={1}
                                    textStyles={[styles.textHeadline, styles.textAlignCenter, styles.pre]}
-                                    shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isThread}
+                                    shouldUseFullTitle={shouldUseFullTitle}


@ginsuma You forgot to negate this condition

This probably caused the regression @Pujan92 found

ginsuma added 2 commits July 20, 2023 16:35

Update ReportSettingsPage permission

96265bf

Update NotificationPreferencePage permission

f2fbb29

ginsuma requested a review from a team as a code owner July 20, 2023 10:56

melvin-bot bot requested review from robertKozik and removed request for a team July 20, 2023 10:56

ginsuma mentioned this pull request Jul 20, 2023

[HOLD for payment 2023-08-02] [HOLD for payment 2023-08-01] [$1000] Web - The first letter of the chat name is cut #22997

Closed

6 tasks

Rename variable

d1a1d29

robertKozik suggested changes Jul 20, 2023

View reviewed changes

Add checking empty report for clear message

f83517c

robertKozik approved these changes Jul 20, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair July 20, 2023 21:48

Merge branch 'main' into fix/22997

30f138b

arosiclair approved these changes Jul 21, 2023

View reviewed changes

arosiclair merged commit 96cee0b into Expensify:main Jul 21, 2023

melvin-bot bot added the Emergency label Jul 21, 2023

arosiclair removed the Emergency label Jul 21, 2023

Pujan92 mentioned this pull request Jul 21, 2023

Fix: Don't truncate long room names in room details page #23357

Merged

58 tasks

robertKozik mentioned this pull request Jul 21, 2023

Fix shouldUseFullTitle #23358

Merged

57 tasks

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

alexxxwork added a commit to alexxxwork/App that referenced this pull request Jul 22, 2023

Update after PR Expensify#23255

3dcce0b

alexxxwork mentioned this pull request Jul 22, 2023

Component refactor: migrate ReportSettingsPage to function component #22927

Merged

57 tasks

BhuvaneshPatil mentioned this pull request Jul 23, 2023

Workspace rooms details page display user list in place of room name #23416

Closed

6 tasks

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

robertKozik reviewed Jul 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ReportSettingsPage and NotificationPreferencePage permission #23255

Update ReportSettingsPage and NotificationPreferencePage permission #23255

ginsuma commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

ginsuma commented Jul 20, 2023

robertKozik commented Jul 20, 2023

robertKozik commented Jul 20, 2023 •

edited

Loading

robertKozik commented Jul 20, 2023 •

edited

Loading

ginsuma commented Jul 20, 2023

alexxxwork commented Jul 20, 2023

robertKozik commented Jul 20, 2023

robertKozik left a comment

robertKozik Jul 20, 2023 •

edited

Loading

ginsuma Jul 20, 2023

robertKozik Jul 20, 2023

robertKozik left a comment

melvin-bot bot commented Jul 21, 2023

arosiclair commented Jul 21, 2023

OSBotify commented Jul 21, 2023

Pujan92 commented Jul 21, 2023

ginsuma commented Jul 21, 2023

robertKozik commented Jul 21, 2023

Pujan92 commented Jul 21, 2023

robertKozik commented Jul 21, 2023

ginsuma commented Jul 21, 2023 •

edited

Loading

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

robertKozik Jul 21, 2023

robertKozik Jul 21, 2023

Update ReportSettingsPage and NotificationPreferencePage permission #23255

Update ReportSettingsPage and NotificationPreferencePage permission #23255

Conversation

ginsuma commented Jul 20, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 20, 2023

ginsuma commented Jul 20, 2023

robertKozik commented Jul 20, 2023

robertKozik commented Jul 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

robertKozik commented Jul 20, 2023 • edited Loading

ginsuma commented Jul 20, 2023

alexxxwork commented Jul 20, 2023

robertKozik commented Jul 20, 2023

robertKozik left a comment

Choose a reason for hiding this comment

robertKozik Jul 20, 2023 • edited Loading

Choose a reason for hiding this comment

ginsuma Jul 20, 2023

Choose a reason for hiding this comment

robertKozik Jul 20, 2023

Choose a reason for hiding this comment

robertKozik left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 21, 2023

arosiclair commented Jul 21, 2023

OSBotify commented Jul 21, 2023

Pujan92 commented Jul 21, 2023

ginsuma commented Jul 21, 2023

robertKozik commented Jul 21, 2023

Pujan92 commented Jul 21, 2023

robertKozik commented Jul 21, 2023

ginsuma commented Jul 21, 2023 • edited Loading

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

robertKozik Jul 21, 2023

Choose a reason for hiding this comment

robertKozik Jul 21, 2023

Choose a reason for hiding this comment

robertKozik commented Jul 20, 2023 •

edited

Loading

robertKozik commented Jul 20, 2023 •

edited

Loading

robertKozik Jul 20, 2023 •

edited

Loading

ginsuma commented Jul 21, 2023 •

edited

Loading