Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix typos in finishReleaseCycle workflow #2304

Merged
merged 2 commits into from
Apr 8, 2021
Merged

[No QA] Fix typos in finishReleaseCycle workflow #2304

merged 2 commits into from
Apr 8, 2021

Conversation

roryabraham
Copy link
Contributor

Details

(hopefully) Fixes failed workflow run: https://github.com/Expensify/Expensify.cash/actions/runs/730486034

Tests

Merge to test 🙃

@roryabraham roryabraham requested a review from deetergp April 8, 2021 18:09
@roryabraham roryabraham self-assigned this Apr 8, 2021
@roryabraham roryabraham requested a review from a team as a code owner April 8, 2021 18:09
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team April 8, 2021 18:09
deetergp
deetergp requested changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's also rename the one in the test from checkForDeployBlockers to checkDeployBlockers also.

@roryabraham
Copy link
Contributor Author

Updated 👍

deetergp
deetergp approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning up my mess!

@deetergp
Copy link
Contributor

deetergp commented Apr 8, 2021

@madmax330 I'm just going to merge it since it's just fixing a name.

@deetergp deetergp merged commit 1359f9f into master Apr 8, 2021
@deetergp deetergp deleted the Rory-FixFinishReleaseCycle branch April 8, 2021 18:34
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Apr 8, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

@madmax330 madmax330 Awaiting requested review from madmax330

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @deetergp @OSBotify