Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WelcomeText component #2190

Merged
merged 6 commits into from
Apr 2, 2021
Merged

Add WelcomeText component #2190

merged 6 commits into from
Apr 2, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Apr 1, 2021 •
edited
Loading

Details

We had some duplicate code in places for the WelcomeText (that will be reused in the SetPasswordPage), so let's refactor that into a single component to makes things cleaner and more modular.

Fixed Issues

Expensify/Expensify#157816

Tests

  1. Navigate to the sign in page
  2. Verify the welcome text everything renders correctly.

QA Steps

  1. Navigate to the sign in page.
  2. Verify the welcome text everything renders correctly.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-04-01 at 11 37 23 AM

Mobile Web

Screen Shot 2021-04-01 at 11 37 28 AM

@jasperhuangg jasperhuangg requested a review from marcaaron April 1, 2021 03:38
@jasperhuangg jasperhuangg requested a review from a team as a code owner April 1, 2021 03:38
@jasperhuangg jasperhuangg self-assigned this Apr 1, 2021
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team April 1, 2021 03:38
@jasperhuangg jasperhuangg requested a review from marcaaron April 1, 2021 04:15
@jasperhuangg jasperhuangg mentioned this pull request Apr 1, 2021
Closed
@jasperhuangg jasperhuangg requested a review from marcaaron April 1, 2021 05:48
thienlnam
thienlnam previously requested changes Apr 1, 2021
View reviewed changes
src/pages/signin/LoginForm/LoginFormNarrow.js Outdated Show resolved Hide resolved
marcaaron
marcaaron requested changes Apr 1, 2021
View reviewed changes
src/pages/signin/LoginForm/LoginFormNarrow.js Outdated Show resolved Hide resolved
src/pages/signin/LoginForm/LoginFormWide.js Outdated Show resolved Hide resolved
@jasperhuangg
Copy link
Contributor Author

@marcaaron @thienlnam ahh duh, brain fart 😅 thanks for the review!

@marcaaron marcaaron dismissed thienlnam’s stale review April 2, 2021 01:01

Gonna dismiss so I can merge it LGTM

@marcaaron marcaaron merged commit 106c52b into master Apr 2, 2021
@marcaaron marcaaron deleted the jasper-welcomeText branch April 2, 2021 01:01
@OSBotify
Copy link
Contributor

OSBotify commented Apr 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcaaron marcaaron marcaaron approved these changes

@thienlnam thienlnam Awaiting requested review from thienlnam

Assignees

@jasperhuangg jasperhuangg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasperhuangg @OSBotify @thienlnam @marcaaron