Fix visible scroll bars on web and non scrollable content on mWeb

[marcaaron]

Details

Overflow scroll creates weird ugly scrollbars on web and modals are not scrolling properly cc @NikkiWines

Also, undoes the height: 0 trick we used here #2101 since it's no longer needed after the other changes.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/158769
Fixes #2147

Tests

1. Navigate to /settings/profile & /settings/password
2. Verify there are no visible scrollbars on web views with content that does not overflow
3. Verify the screen can be scroll on smaller screen mobile views if the content overflows

Test New Group Button appears

1. Navigate to New Group screen
2. Verify options can be scrolled
3. Select 4 options
4. Verify the Create Group button appears

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

2021-03-29_16-12-37.mp4

Desktop

2021-03-29_16-57-35.mp4

iOS

Android

[marcaaron]

Tossing this back into draft for a second mWeb seems kinda broken in simulator

[marcaaron]

@jasperhuangg adding you as a reviewer here since I think this is the proper fix for the issues fixed by #2101, but lmk if I'm missing anything.

[jasperhuangg]

@marcaaron Looks good! I tested it out on my end and verified everything works great, including the inability to scroll that was addressed in the past issue.

[shawnborton]

Another place to check for testing - does this work in the "New Group" flow where after selecting a person, the "Create Group" button is added to the bottom of the screen?

[bondydaa]

I'm confused... in your videos I do see scroll bars

[bondydaa]

code changes seem bueno 👍

[marcaaron]

@shawnborton yes it works, but I'll add it as a testing step for good measure

[marcaaron]

I'm confused... in your videos I do see scroll bars

@bondydaa Updated the tests steps but see the original issue, it's confusing as there are two issues

1. Screens that should scroll are not able to scroll at all
2. On web, screens that should not scroll (no content overflow) non functional scrollbars are shown

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.