Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Missing Email in Workspace invite page #20823

Merged
merged 4 commits into from
Jun 15, 2023
Merged

[Fix] Missing Email in Workspace invite page #20823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e925f7d
[Fix] Missing Email
fedirjh Jun 15, 2023
88df928
[Fix] PropType mismatch
fedirjh Jun 15, 2023
fa80a42
[Fix] PropType mismatch
fedirjh Jun 15, 2023
2cad3a6
Simplify
fedirjh Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/OptionsListUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ function getPersonalDetailsForAccountIDs(accountIDs, personalDetails) {
let personalDetail = personalDetails[accountID];
if (!personalDetail) {
personalDetail = {
accountID: cleanAccountID,
avatar: UserUtils.getDefaultAvatar(cleanAccountID),
};
}
Expand All @@ -190,6 +189,7 @@ function getPersonalDetailsForAccountIDs(accountIDs, personalDetails) {
personalDetail.avatar = CONST.CONCIERGE_ICON_URL;
}

personalDetail.accountID = cleanAccountID;
personalDetailsForAccountIDs[cleanAccountID] = personalDetail;
});
return personalDetailsForAccountIDs;
Expand Down Expand Up @@ -475,7 +475,7 @@ function createOption(accountIDs, personalDetails, report, reportActions = {}, {
} else {
reportName = ReportUtils.getDisplayNameForParticipant(accountIDs[0]);
result.keyForList = String(accountIDs[0]);
result.alternateText = '';
result.alternateText = LocalePhoneNumber.formatPhoneNumber(lodashGet(personalDetails, [accountIDs[0], 'login'], ''));
}

result.isIOUReportOwner = ReportUtils.isIOUOwnedByCurrentUser(result, iouReports);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/sidebar/SidebarLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ const personalDetailsSelector = (personalDetails) =>
// It's OK to do param-reassignment in _.reduce() because we absolutely know the starting state of finalPersonalDetails
// eslint-disable-next-line no-param-reassign
finalPersonalDetails[accountID] = {
accountID,
accountID: Number(accountID),
login: personalData.login,
displayName: personalData.displayName,
firstName: personalData.firstName,
Expand Down